Posted by jjeff on August 19, 2007 at 6:00am
Jump to:
| Project: | Drupal core |
| Version: | 5.x-dev |
| Component: | theme system |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
For sites that allow anonymous commenting, Drupal asks for a "Homepage" from the author of the comment. This has become a huge spam magnet. This patch adds rel="nofollow" to these links when rendered by theme_username. Simple and easy way to stop any benefit to spammers.
Patch should also apply for Drupal 5.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| d6-theme-uname-nofollow.patch.txt | 707 bytes | Ignored: Check issue status. | None | None |
Comments
#1
Well, not good news, but committed!
#2
Setting back to RTBC for a D5 backport ?
#3
This is not a critical bug, because it doesn't stop Drupal from working. Lowering its priority to 'normal' (although I think it should be 'minor').
#4
Shouldn't this be configurable? "dofollows" are seen as a reward for regular visitors/commenters on (smaller) websites.
#5
It is still as themeable as it as before, we just changed the default.
#6
I am not sure that we should require a theme change on 5.x upgrade if users want to keep their current non-nofollow. Leaving as "needs review" since this is debatable.
Patch does apply cleanly to 5.x.
#7
I think if we're making a change we should add a config option like Wim suggests. Since we provide a nofollow config checkbox for the urlfilter in core, we should be consistent and include one on the comment settings page as well IMO.
#8
This should not be mandatory. It should be configurable, with nofollow turned off by default (same as for input filters).
#9
Agreed. There should be a configuration. It should default to nofollow.
Who wants to code it?
In the meantime, before we have a configuration, we should leave nofollow to deter spammers.
#10
Spammers actually check for "nofollow"? I thought they spammed regardless. :)
To whoever codes it:
How about unifying the admin ui so controlling nofollow doesn't become a chore of digging through input filters so it's enabled on the post body also.
[edit: Just realized I'm repeating here.. +1 to getting this done.]
#11
dvessel: Spammers ignore nofollow, but Google does not. The idea is that if a spammer hits your site and floods your comments with links to viagra sites, search engines will see the nofollow and, er, not follow them, so the spammers links aren't as effective. Your site still has a crapload of links to remove, though.
#12
I don't think it should default to nofollow. Nofollow is a controversial microformat (see the microformats wiki).
Also, the comment body text is not nofollowed by default so nofollowing just the comment homepage link won't really help.
I think there should be the option to turn on nofollow, but not as default.
#13
We're almost at Drupal 7, safe to say now that this won't be backported to D5.