Closed (fixed)
Project:
ACL
Version:
5.x-1.4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Aug 2007 at 22:41 UTC
Updated:
23 Nov 2007 at 10:11 UTC
Jump to comment: Most recent file
Hi
I was having issues with the Forum Access module and noticed that acl_id created without $db_prefix added when using a shared sequences table.
Keith.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | acl.070822c.patch.txt | 1.85 KB | salvis |
| #2 | acl.070822b.patch.txt | 1.57 KB | salvis |
| #1 | acl.070822.patch.txt | 1.38 KB | salvis |
Comments
Comment #1
salvisFix it. Thanks to hgmichna for mentioning the need to rename the existing entry, in http://drupal.org/node/159134.
Comment #2
salvisAdd missing PostgreSQL code.
BTW, gypsymanz suspects in http://drupal.org/node/133270 that this issue can cause misbehavior of Forum Access. I can't see how this could happen, but when I look through Drupal core and contrib, I see the sequences prefixed with the $db_prefix everywhere, so that seems to be the standard.
Please don't try this on a production site before merlin has given the green light, because messing with the acl_ids could cause havoc for your access permissions!
Comment #3
salvisAnother missing piece of PostgreSQL code.
Comment #4
merlinofchaos commentedThis patch looks pretty reasonable and ought to work.
Note that if you're already sharing a sequence table then probably every ACL is going to be messed up, and will have to be removed. And yea, this could affect forum access if you've got shared sequences table going on. It might require completely uninstalling the module to eliminate the tables and then reinstalling and starting the forum privacy from scratch.
Comment #5
gypsymanz commentedThe patch works a treat.
The entry in the sequences table is created as $db_prefix_acl_acl_id is the double 'acl' deliberate ?
Thanks for your help and patients,
Keith
Comment #6
merlinofchaos commentedYes, the actual field is acl.acl_id, so when you add the db prefix you get dbprefix_acl_acl_id.
I'll apply this patch; or hopefully, one of my comaintainers will see this and apply it.
Comment #7
merlinofchaos commentedComment #8
fagoops. Looks like I have forgotten to subscribe to the acl issues, sry.
Finally, committed to 5.x-dev.
Comment #9
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.