Hi
I was having issues with the Forum Access module and noticed that acl_id created without $db_prefix added when using a shared sequences table.

Keith.

Comments

salvis’s picture

Status: Active » Needs review
StatusFileSize
new1.38 KB

Fix it. Thanks to hgmichna for mentioning the need to rename the existing entry, in http://drupal.org/node/159134.

salvis’s picture

StatusFileSize
new1.57 KB

Add missing PostgreSQL code.

BTW, gypsymanz suspects in http://drupal.org/node/133270 that this issue can cause misbehavior of Forum Access. I can't see how this could happen, but when I look through Drupal core and contrib, I see the sequences prefixed with the $db_prefix everywhere, so that seems to be the standard.

Please don't try this on a production site before merlin has given the green light, because messing with the acl_ids could cause havoc for your access permissions!

salvis’s picture

StatusFileSize
new1.85 KB

Another missing piece of PostgreSQL code.

merlinofchaos’s picture

This patch looks pretty reasonable and ought to work.

Note that if you're already sharing a sequence table then probably every ACL is going to be messed up, and will have to be removed. And yea, this could affect forum access if you've got shared sequences table going on. It might require completely uninstalling the module to eliminate the tables and then reinstalling and starting the forum privacy from scratch.

gypsymanz’s picture

The patch works a treat.

The entry in the sequences table is created as $db_prefix_acl_acl_id is the double 'acl' deliberate ?

Thanks for your help and patients,

Keith

merlinofchaos’s picture

Yes, the actual field is acl.acl_id, so when you add the db prefix you get dbprefix_acl_acl_id.

I'll apply this patch; or hopefully, one of my comaintainers will see this and apply it.

merlinofchaos’s picture

Status: Needs review » Reviewed & tested by the community
fago’s picture

Status: Reviewed & tested by the community » Fixed

ops. Looks like I have forgotten to subscribe to the acl issues, sry.

Finally, committed to 5.x-dev.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.