Hi:
I think it'll be nice to have the ability to exclude certain paths from the log. I'm running performance tests on my site and I don't want to log paths such as admin* or others. I'm willing to provide a patch if you think is interesting.
Regards.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | performance-skip_certain_paths-1687656.patch | 2.77 KB | trisketonni |
Comments
Comment #1
malc0mn commentedOh this is definitely something I've been thinking about adding for a while... We would probably need something like the blocks 'display on all pages except' and a texfield like:
etc.
I've been thinking about excluding drush from the logging as well, but didn't dig deeper into this yet. Hopefully drush sets some constant so that we can check if drush is accessing the site (like update.php does with
define('MAINTENANCE_MODE', 'update');)...Edit: maybe
DRUSH_DRUPAL_BOOTSTRAP?Not sure if the check on the path should be in hook_boot() or the shutdown function. Probably the shutdown function as a check in hook_boot() will slow the site down a bit, and we don't want that in the Performance module ;-)
Comment #2
malc0mn commentedDRUSH_DRUPAL_BOOTSTRAPwas definitely the way to go. Implemented it at once for D6 and D7. Feel free to supply a patch for the path exclusion feature ;-)Comment #3
trisketonni commentedHere is the patch. I hope you like it.
Comment #4
malc0mn commentedIt's perfect! I was really wondering how you would handle the path matching. Never knew about drupal_match_path(). Will apply it somewhere this week!
Comment #5
malc0mn commentedApplied patch to D6 and D7. Available in next release. Thanks a lot for the work!
mlc.