*_node_form cache loading prevents files to be attached to node on direct save/update [#168813]

Comment	File	Size	Author
#9	upload_submit.patch	3.99 KB	chx

#6	upload.module_47.patch	950 bytes	julien

#4	upload.module_46.patch	1.16 KB	fwalch

Comment #1

julien CreditAttribution: julien commented 29 August 2007 at 15:39

I have reproduce this issue, and i have seen that when you save before the preview, it appears in the table file, but not in the table upload, which is the table used to see the files attachement.
I have insert manualy a record with the fid of the file in the table file, and now it appears.
I'm trying to locate where is the sql query and i will change it when i will find it.
If someone know in which file is this query, it will help me.

Log in or register to post comments

Comment #2

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 29 August 2007 at 20:25

Oh, this would be great to get fixed in beta 1 indeed.

Log in or register to post comments

Comment #3

drewish CreditAttribution: drewish commented 29 August 2007 at 22:05

it looks like the root of it is that hook_nodeapi($op='view') is now being called before hook_nodeapi($op='prepare'). prepare is where the files are attached. so if you click preview twice the files are attached properly.

Log in or register to post comments

Comment #4

fwalch CreditAttribution: fwalch commented 29 August 2007 at 22:34

Status:

Active

» Needs review

File	Size
upload.module_46.patch	1.16 KB

I found out that if you just save the node, no files are attached to the node object. If you preview first, "_upload_prepare" is called, which attaches the files.
This patch checks if all files are attached to the node and adds missing ones, which fixes the bug.

Log in or register to post comments

Comment #5

drewish CreditAttribution: drewish commented 29 August 2007 at 23:11

Status:

Needs review

» Needs work

previews don't work. you still have to click preview twice.

Log in or register to post comments

Comment #6

julien CreditAttribution: julien commented 30 August 2007 at 03:13

File	Size
upload.module_47.patch	950 bytes

I have apply the patch 46, and add a line in the case 'view' to prepare the node. It will put the file in the table upload only after clicking on save.

Log in or register to post comments

Comment #7

chx CreditAttribution: chx commented 30 August 2007 at 04:46

I am on the case. Seems when saving a node form, nodeapi op prepare is not called. WTF?

Log in or register to post comments

Comment #8

chx CreditAttribution: chx commented 30 August 2007 at 04:51

Title:	upload module deletes files on submission	» Cached node forms do not call op prepare
Assigned:	Unassigned	» chx

Log in or register to post comments

Comment #9

chx CreditAttribution: chx commented 30 August 2007 at 05:23

Title:	Cached node forms do not call op prepare	» upload prepare is the wrong operation
Status:	Needs work	» Needs review

File	Size
upload_submit.patch	3.99 KB

upload_prepare operates on submitted info, that hardly belongs to op prepare. I fixed a few notices as I went. The patch has known issues, on edit I got a surplus line saying "0 1" in the file attachment table, as time permits I will fix that. But essentially this works.

Log in or register to post comments

Comment #10

chx CreditAttribution: chx commented 1 September 2007 at 11:50

Title:	upload prepare is the wrong operation	» *_node_form cache loading prevents files to be attached to node on direct save/update
Status:	Needs review	» Needs work

Twin issue was http://drupal.org/node/164674 but as I patched this, that one is now duplicate.

Log in or register to post comments

Comment #11

chx CreditAttribution: chx commented 1 September 2007 at 18:44

Status:

Needs work

» Needs review

I have just tested the patch and it works. I suspect dvessel's patches...

Log in or register to post comments

Comment #12

dvessel CreditAttribution: dvessel commented 1 September 2007 at 19:17

Status:

Needs review

» Reviewed & tested by the community

chx, I misunderstood.. The patch does indeed work. Got confused by how this issue was progressing so I never applied the patch. duh..

Not related to this, but in Safari 2 clicking the "attach" button shows the progress animation but never finishes. Just clicking save without previews works fine.