Posted by ronan.orb on July 17, 2012 at 12:41pm
4 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | documentation |
| Category: | bug report |
| Priority: | normal |
| Assigned: | mjonesdinero |
| Status: | closed (fixed) |
| Issue tags: | needs backport to D7, Novice |
Issue Summary
API page: http://api.drupal.org/api/drupal/modules%21taxonomy%21taxonomy.module/fu...
Enter a descriptive title (above) relating to taxonomy_term_load, then describe the problem you have found:
If $tid not found, FALSE is returned. NULL would be also assumable.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| added_Return_message1.patch | 539 bytes | Idle | FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in added_Return_message1.patch. | View details |
Comments
#1
Thanks for the patch! See http://drupal.org/node/1689394#comment-6244396 for a note on patch formatting.
So this patch needs to be rerolled using Git, and also:
- Line wrapping -- move the added text up to the previous line, and wrap at 80 characters.
- Add "the" to "FALSE if *the* term was not found.".
#2
re roll the patch..
#3
The last submitted patch, taxonomy_term_load-does-not-1689426-2.patch, failed testing.
#4
sorry about the last patch submitted it was for d7 i thought it is for d7 but also in d8..
attach is the patch now for d8.
#5
Thanks!
This line is missing a space:
+ * A taxonomy term entity. Results are statically cached.FALSE if the termAnd maybe it would be better to say "... term entity, or FALSE if the term ..." rather than putting that at the end?
#6
okie re-rolled the patch, git pull first for the update on the patch commited.
attach is the updated patch now..
#7
#8
Looks good, thanks! I'll get it committed shortly.
#9
Committed to 8.x. The patch doesn't apply to 7.x, so we need a reroll.
#10
re-rolled the patch for D7
#11
Thanks! I'll get this committed soon.
#12
Committed to 7.x now too. Thanks again!
#13
Automatically closed -- issue fixed for 2 weeks with no activity.