Follow-on from #1035410: Flag any entity.

Flag objects now store the entity info for their entity type when initially constructed, so that they can pull data from it whenever required (such as labels, bundles, key names, etc etc).

The alternative would be to call entity_get_info() every time something is needed from that data.

I have no idea which would be better for performance. Any thoughts?

CommentFileSizeAuthor
#2 1689704.flag_.remove-stored-entity-info.patch3.46 KBjoachim

Comments

joachim’s picture

joachim commented
Priority: Normal » Major

The decision has been made for us by #871064: Making flaggings fieldable, which would cause circularity here:

The hook_entity_info() added by that patch goes to look at which flag types we have in order to know about flagging bundles. But the flag_entity class calls entity_get_info() in its constructor.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1689704.flag_.remove-stored-entity-info.patch3.46 KB

Here's a patch for review & the testbot.

joachim’s picture

joachim commented

... which wasn't enabled.

Hopefully a new comment will kick it into action :)

joachim’s picture

joachim commented
Status: Needs review » Fixed

Tests pass, and we need it for #871064: Making flaggings fieldable, and I was a bit iffy about this anyway. Committing!

Issue #1689704 by joachim: Changed flag object to retrieve entity info rather than store it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.