Closed (fixed)
Project:
Send
Version:
master
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Aug 2007 at 18:56 UTC
Updated:
17 Mar 2008 at 03:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
jerdavisThe link suppression is currently not working correctly, I believe this is attributed to the hierarchical method of storing settings for the module and any sub modules - but I've confirmed this to not work correctly under HEAD.
I've created a patch against head which changes the link suppression from blank to <none>. Using a blank line allowed for the default settings from further up the tree to take over. Entering <none> on a per-node basis, or per-type basis allows you to properly suppress the link and present it only on select nodes.
Comment #2
allie mickaI love this idea of using <none> to hide the link text - it's very clear and consistent with other parts of Drupal. I have updated the help text a little to explain what's going on.
This uncovers an additional issue/question of what to do with empty values. My inclination is to have _send_value() delete values that are empty strings so that items can pick up the value from the next level up ( e.g. clearing the value on the "Page" content type will cause pages to pick up the default values.
I'd like to test these changes together so that we can get them into an update hook.
Thanks!
Comment #3
allie mickaComment #4
jerdavisUpdating with another patch...
Comment #5
jerdavisThis patch adds some cleanup to send.install for existing instances of a null linktext, and also adds a delete to the _send_value() function that removes values which have been set to null.
Comment #6
allie mickaCommitted - THANKS!
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.