Due to imagecache's use of the drupal image_scale function, it does not upscale images smaller than the selected dimensions on the imagecache presets page.
This is very confusing when you are trying to scale up an image to 'outside' dimensions and then crop it to a fixed size -- depending on the input images, it can appear as if that imagecache is scaling to inside dimensions, etc etc.
Adding this note on the download page or in the README will be very useful to developers not familar with drupal and has the potential to save some developers a lot of time! Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | imagecache_15.patch | 2 KB | nicholasthompson |
Comments
Comment #1
nicholasthompsonI attach a patch which allows imagecache to also up-scale images.
Its basically a copy of the image_scale function from image.inc with a few lines removed to allow it to up-scale.
Some people prefer images to NOT up-scale... So maybe this patch needs revising to allow a switch/override?
Please review and revise! :-)
Comment #2
ragaskar commentedthanks, I upgraded to HEAD and it pretty much fixed all my issues. ;)
Comment #3
nicholasthompsonSeems the patch didn't attach last time... Which is odd!
Here is the patch (I HOPE)
Comment #4
ms2011 commented+1 for imagecache upscaling.
Confirm patch works.
Thanks nicholasThompson! :)
Comment #5
dopry commentedI'm not sure if I wouldn't rather add a transparent border instead of upscaling and madly distorting the image....
What say you pros and cons?
Comment #6
nicholasthompsonI agree that upscaling and distorting images is not always ideal. It might be best, for example, to allow a parameter to be set to determine what happens to an image which is set to be scaled to a size larger than its default...
1) No upscale
2) Upscale regardless
3) Return image of required size with appropriate padding around it
For option 3 one might also want a parameter to determine the colour of the padding. This adds extra and, in my opinion, unnecessary complication.
I think it would suffice to simply have upscaling as an option.
I found it useful to be able to upscale a small avatar to a size which fits neatly into a specified area on, for example, a profile page. If the user then does not like the blocky avatar they always have the option to upload and overwrite with a new avatar as larger ones will scale down nicely whereas smaller will not scale up nicely.
Comment #7
dopry commentedThis is in HEAD.... there is an upscale flag on the scale action.
Comment #8
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.