Cleanup of Administration Link

pjb - August 21, 2007 - 11:25
Project:Avatar Approval
Version:5.x-1.x-dev
Component:User interface
Category:feature request
Priority:minor
Assigned:Unassigned
Status:won't fix
Description

This is a nit (silly patch attached), but 'Approval' is a rather general name for the link to the GUI for approving avatars; changed to 'Avatar Approval' :)

AttachmentSize
avatarapproval_patch.txt525 bytes

#1

mikejoconnor - August 21, 2007 - 14:41

Actually, I think its a great suggestion, I'll have some time later to day to take a look at it.

Thanks for the patch,

Mike O.

#2

pjb - August 22, 2007 - 00:40

Glad you think it's worthwhile, but it actually it looks as if I have jumped the gun. I didn't realize this was tying into other modules such as 'nodeapproval' and 'commentapproval'; when viewed in that respect, a generic name of 'Approvals' is probably appropriate :)

#3

mikejoconnor - August 22, 2007 - 00:55

When I quickly looked at the patch, it appeared that it would only change the menu if the other modules in the approval suite were not installed. The real question is, although it makes sense if only the avatar approval module is installed, would it hinder the overall usability of the suite when a user adds another approval module, and the 'avatar approval' menu is replaced by the generic 'approval'.

#4

mikejoconnor - October 24, 2007 - 02:47
Status:patch (code needs review)» won't fix

Although the menu doesn't make a lot of sense if you are just using the Avatar approval module, it works very well if you are using other modules in the approval suite(comment approval, and nodeapproval).

 
 

Drupal is a registered trademark of Dries Buytaert.