Disabled local fonts are shown along with enabled fonts, and CSS selectors can be assigned to them, leading to misunderstanding about their status.
Add 'Enable' link for disabled fonts (although enabling is available under 'Edit', this change would bring it closer - from three clicks to two - and make more visible);
Replace CSS selector with 'Font disabled' message.
See attachment for an example.
#1544156: [META] Simplify/reduce which functionality is available on which screens
Possibly related: #1679914: Local Fonts Prevent each other from loading
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | fontyourface-Improve_UI_for_local_fonts_to_reduce_confusion-1692468-1.patch | 2.16 KB | Drave Robber |
| localfonts19Jul.png | 128.97 KB | Drave Robber |
Comments
Comment #1
Drave Robber commentedHere's the patch.
Comment #2
sreynen commentedThis makes it clear which fonts are disabled on the "Enabled fonts" screen, but I think it's still a problem that we have a screen titled "Enabled fonts" that includes disabled fonts at all. This patch makes that problem much clearer, which is good. But I think we should solve that problem more directly.
Looking back at the issue where we added disabled fonts to that screen, we talked about a few different places we could add delete links and I think we made a mistake in choosing what was at the time the "Apply" screen (which later became "Enabled fonts").
I think what we should have done instead, and what we should go back and do now, is add a delete link to the local fonts browse interface. That's going to be a little more complicated, since that's a more custom interface, but I think it's a good step toward consolidating more functionality on fewer screens.
Currently the entire bottom of a font in the browse interface is the enable link. I think for disabled local fonts, we should split up the bottom into enable on the left and a small X (maybe this) on the bottom right, linking to the delete confirmation screen.
Comment #3
sreynen commentedLet's just go ahead with #1 for D7 and leave the bigger change for D8.
Comment #4
Drave Robber commentedThis has been committed.