Instead of popping the link up in a new window, this gives designers the option to open all external links in a popup frame using http://vikjavev.no/highslide/. (See http://vikjavev.no/highslide/#examples and click on "Content in iframe" to see an example of how it works.) It is essentially a popup div containing an iframe. I have also added the options to set the target to _self _parent and _top instead of just _blank. (I had to add the .txt extension to upload. Rename without the .txt) This patch is sponsored by www.numbersusa.com

CommentFileSizeAuthor
#9 thickbox.patch8.25 KBSolomonGifford
#9 thickbox.tar_.gz14.27 KBSolomonGifford
withpopup.tar_.gz_.txt79.64 KBSolomonGifford

Comments

SolomonGifford’s picture

SolomonGifford commented
Assigned: SolomonGifford » Unassigned

Should be renamed withpopup.tar.gz

You will want to uninstall the current release on your installation and then install this one "or" replace all contents of the extlinks folder with those in the gz.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Needs work

Contributions that are not in patch form have no chance of being integrated into the existing module. Could you have a look at the patch instructions (http://drupal.org/patch/create) and roll a patch for your changes?

randomuser’s picture

randomuser commented

Hey, I'm using Drupal 5.x and have replaced the old module code with the patch from above but unfortunetly nothing happens either when I click an external link or a picture.

Is there a settings file somewhere that I need to change? It might be an idea to have extra options in the External Links module admin page.

I really want to see this, the demo of Highslide looks good so some Drupal integration is ideal, thanks for taking the time to do this.

Anyone else got this working?

SolomonGifford’s picture

SolomonGifford commented

The extra options are in the admin page, so there's a problem with your install (or my tar).

I've actually made some further progress on this module. Email me at solomongifford at gmail dot com for the latest.

I haven't taken the time time make a patch and uploading a txt will just get me yelled at again.

SolomonGifford’s picture

SolomonGifford commented
Status: Closed (won't fix) » Needs work
wisdom’s picture

wisdom commented

I can not download the patch withpopup.tar_.gz_.txt I think the problem is the attachment has a .txt extension for a gz file which looks very strange. When I try to download it displays a garbage ( meaningless characters) on the screen both in ie and firefox.

StevenSokulski’s picture

StevenSokulski commented

It appears as though the file listed above has been removed. Any updates on this? Or a patch?

SolomonGifford’s picture

SolomonGifford commented

contact me solomongifford at gmail dot com for my latest...if someone is interested in adding this to the module I'd be glad to help.

SolomonGifford’s picture

SolomonGifford commented
Status: Needs work » Needs review
StatusFileSize
new thickbox.tar_.gz14.27 KB
new thickbox.patch8.25 KB

I've finally added this as a patch.

Untar the (slightly modified) thickbox from the modules directory (it will untar into the extlink/thickbox directory).

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Closed (won't fix)

I'm not going to add this feature to Extlink because it is very site-specific and adds a significant amount of complexity and dependencies (such as thickbox). If rewritten in a way that provides compatibility with other libraries (such as lightbox, thickbox, greybox, highslide) without actually including or hard-coding any reference to them it might be worth revisiting (such as adding a "rel" attribute to external links).

elachlan’s picture

elachlan commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)