Popup in Iframe and set other targets.
solomongifford - August 21, 2007 - 17:12
| Project: | External Links |
| Version: | 5.x-1.3 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Description
Instead of popping the link up in a new window, this gives designers the option to open all external links in a popup frame using http://vikjavev.no/highslide/. (See http://vikjavev.no/highslide/#examples and click on "Content in iframe" to see an example of how it works.) It is essentially a popup div containing an iframe. I have also added the options to set the target to _self _parent and _top instead of just _blank. (I had to add the .txt extension to upload. Rename without the .txt) This patch is sponsored by www.numbersusa.com
| Attachment | Size |
|---|---|
| withpopup.tar_.gz_.txt | 79.64 KB |
#1
Should be renamed withpopup.tar.gz
You will want to uninstall the current release on your installation and then install this one "or" replace all contents of the extlinks folder with those in the gz.
#2
Contributions that are not in patch form have no chance of being integrated into the existing module. Could you have a look at the patch instructions (http://drupal.org/patch/create) and roll a patch for your changes?
#3
Hey, I'm using Drupal 5.x and have replaced the old module code with the patch from above but unfortunetly nothing happens either when I click an external link or a picture.
Is there a settings file somewhere that I need to change? It might be an idea to have extra options in the External Links module admin page.
I really want to see this, the demo of Highslide looks good so some Drupal integration is ideal, thanks for taking the time to do this.
Anyone else got this working?
#4
The extra options are in the admin page, so there's a problem with your install (or my tar).
I've actually made some further progress on this module. Email me at solomongifford at gmail dot com for the latest.
I haven't taken the time time make a patch and uploading a txt will just get me yelled at again.
#5
Hey all. I have worked on a version 2 of this. It works on the same principles but instead of using highslide, which has its own javascript library, it uses thickbox, which is based on jquery (which ships with drupal 5). This should decrease load time and be more consistent with what drupal already is doing.
If someone has time to convert my latest modifications into a patch I would appreciate it. That way the drupal masters can take a look at it. http://dev.numbersusa.com/drupal/fb/extlink_modified.tar.gz
#6
I can not download the patch withpopup.tar_.gz_.txt I think the problem is the attachment has a .txt extension for a gz file which looks very strange. When I try to download it displays a garbage ( meaningless characters) on the screen both in ie and firefox.
#7
It appears as though the file listed above has been removed. Any updates on this? Or a patch?
#8
contact me solomongifford at gmail dot com for my latest...if someone is interested in adding this to the module I'd be glad to help.
#9
I've finally added this as a patch.
Untar the (slightly modified) thickbox from the modules directory (it will untar into the extlink/thickbox directory).
#10
I'm not going to add this feature to Extlink because it is very site-specific and adds a significant amount of complexity and dependencies (such as thickbox). If rewritten in a way that provides compatibility with other libraries (such as lightbox, thickbox, greybox, highslide) without actually including or hard-coding any reference to them it might be worth revisiting (such as adding a "rel" attribute to external links).