Sometimes a service requires empty verification file and it is impossible to create such file with Site Verification module, because the module prints "Verification page" instead of empty verification file.

Patch follows.

CommentFileSizeAuthor
#1 site_verify-1694022-1.patch1.09 KBdmitriy.trt

Issue fork site_verify-1694022

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dmitriy.trt’s picture

dmitriy.trt commented
Status: Active » Needs review
StatusFileSize
new site_verify-1694022-1.patch1.09 KB
cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Issue summary: View changes

Correct module name

chris matthews’s picture

chris matthews commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll, +Needs rework

The 6 year old patch to site_verify.module does not apply to the latest 7.x-1.x-dev and may be too old to reroll, but I went ahead and tagged the issue accordingly.

Checking patch site_verify.module...
error: while searching for:

function site_verify_output($svid) {
  $verification = site_verify_load($svid);
  if ($verification['file_contents'] && $verification['engine']['file_contents']) {
    echo $verification['file_contents'];
  }
  else {
    drupal_set_title(t('Verification page'));
    return t('This is a verification page for the @title search engine.', array('!title' => $verification['engine']['name']));
  }
}

error: patch failed: site_verify.module:177
error: site_verify.module: patch does not apply

elc made their first commit to this issue’s fork.

elc opened merge request !4

elc’s picture

elc commented
Status: Needs work » Needs review
Issue tags: -Needs reroll, -

Re-rolled into MR.

elc’s picture

elc commented
Status: Needs review » Reviewed & tested by the community

Serves up the contents of the file, epty or not, provided the engine has file_contents enabled for it. Tested it provides the empty contents and created the MR, so setting to RTBC.

  • elc committed 4199092f on 7.x-1.x authored by dmitriy.trt 
    [#1694022] by dmitriy.trt: Support empty verification file.
elc’s picture

elc commented
Status: Reviewed & tested by the community » Fixed
elc’s picture

elc commented
Version: 7.x-1.x-dev » 2.1.x-dev
Assigned: Unassigned » elc
Status: Fixed » Patch (to be ported)

This issue is still present in the 2.1.x branch.

Notable behaviour change for the module.

elc opened merge request !12

  • elc committed 647630fa on 2.1.x authored by dmitriy.trt 
    [#1694022] by dmitriy.trt: Support empty verification file.
elc’s picture

elc commented
Assigned: elc » Unassigned
Status: Patch (to be ported) » Fixed

phpcs issue will be fixed as part of the next issue merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.