Follow-up to #1444866: UI for translation of menu items for entity-translated nodes.

EntityTranslationNodeHandler::menuFormSubmit() contains the following @todo item:

@todo Remove this once hook implementation calling order is fixed.

I'm not sure what the exact problem was, but sounds like this needs fixing... :)

CommentFileSizeAuthor
#2 et-module_implements-1694480-2.patch10.53 KBplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Title: Fix hook implementation calling order » Implement hook_module_implements() instead of relying on the module weight
Component: Menu integration » Base system

Don't remember exactly what that todo means, but it surely refers to implementing hook_module_implements() instead of relying on the module weight.

Added this to the road map: #1624830: Plan for Entity Translation 7.x-1.0 release.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
StatusFileSize
new et-module_implements-1694480-2.patch10.53 KB

The attached patch fixes the OP by implementing hook_module_implements_alter(). There is also some code moved around to clean up the hook implementation portion of the entity_translation.module. No code change there.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Also menu tests are green locally.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Duplicated by #1345932: Replace fixed module weight with hook_module_implements_alter()

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Issue summary: View changes

Added reference to original issue which added the @todo.

  • Commit 4f05997 on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions by plach: 
    Issue #1694480 by plach | bforchhammer: Implement hook_module_implements...

  • Commit 4f05997 on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions, workbench by plach: 
    Issue #1694480 by plach | bforchhammer: Implement hook_module_implements...