Download & Extend
Menu attributes » Issues

Update 7001 failing on Drupal 6-7 upgrade.

Posted by hedinfoto on July 20, 2012 at 4:22pm
Project:Menu attributes
Version:7.x-1.0-rc2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

Drupal 6 version: version = "6.x-2.0-beta1"
Drupal 7 version: version = "7.x-1.0-rc2"
Ran upgrade php in D7 with no modules (ran with no pending update success) then installed the modules and ran again.

Update #7001
Failed: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'module' cannot be null: INSERT INTO {role_permission} (rid, permission, module) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_0] => 4 [:db_insert_placeholder_1] => administer menu attributes [:db_insert_placeholder_2] => ) in user_role_grant_permissions() (line 3034 of /home/trunk-7/modules/user/user.module).

Code that is not running:

/**
* Grant the 'administer menu attributes' permission to roles that currently
* have the 'administer menu' permission.
*/
function menu_attributes_update_7001() {
  $roles = user_roles(FALSE, 'administer menu');
  foreach ($roles as $rid => $role) {
    user_role_grant_permissions($rid, array('administer menu attributes'));
  }

  return t("Every role with the 'administer menu' permission has also received the 'administer menu attributes' permission.");
}

Anybody else having issues with this part of the upgrade?

Login or register to post comments

Comments

#1

Posted by jeremyr on July 26, 2012 at 8:04pm

Having this exact problem today on D7.

#2

Posted by jeremyr on July 26, 2012 at 8:12pm

It seems that the module "Menu Attributes" was not enabled. So I turned it on and the update ran just fine. For what it's worth....

#3

Posted by screenack on July 27, 2012 at 1:41am

For the record, this isn't limited to D6 -> D7 updates. I just experienced it upgrading from 7.x-1.0-rc1 to rc2.

Yes, my module was disabled. Enabling the module enabled the update. Jeremyr saved me a whole lot of head scratching; thanks!

#4

Posted by jeremyr on July 27, 2012 at 1:49am

Glad I helped you out. We updated a number of D7 sites today and only one out of +/-50 had this issue.

#5

Posted by amateescu on August 3, 2012 at 11:29am
Status:active» fixed

Hm.. so this is fixed then?

#6

Posted by screenack on August 3, 2012 at 12:07pm

amateescu: what data are you using to change this status to "fixed"?

#7

Posted by amateescu on August 3, 2012 at 12:10pm

Comments #2 and #3.

#8

Posted by screenack on August 3, 2012 at 12:19pm
Status:fixed» active

This thread indicates that we have a work-around, not a solution. Unless we expect disabled modules to throw errors? I've set this back to active.

#9

Posted by amateescu on August 3, 2012 at 12:20pm

Ok, as you wish :)

#10

Posted by cmsdave on August 6, 2012 at 9:30pm

Had the same issue. In my case, it was also because the module was off. Turning it back on resolved the issue.

I agree with screenack's point that I wouldn't have expected to see this error given that the module was disabled.

#11

Posted by VM on October 25, 2012 at 5:34pm
Status:active» fixed

I think the problem is a documentation issue at this point. If modules are disabled the code to update them can't run when needed. There are core discussions on this and ultimately, the instructions to disable modules before updating them may currently be a misleading and unneeded step.

#12

Posted by VM on October 25, 2012 at 5:34pm
Status:fixed» active

didn't mean to switch status.