The Basic Toolbox, when selected for the Addthis Block, only shows the icons for facebook and twitter. It doesn't seem to take any of its settings from the configured services on the main addthis page, and it doesn't have the ability to write in services, separated by commas, like in the Content Type, Manage Display settings.

Updated: Comment #16

Problem/Motivation

The AddThis module contains a block. This block now allows to choose between the available displays. But it only uses the defaults of that display.

- Add the block.
- Select the Toolbox display.
- Results in only facebook and twitter icon.

Proposed resolution

  • #8: First a patch was proposed with a form with states that added both the default implemented displays into the form.
  • #15: The second solution is implement the same technique used by fields to select the display and be able to use the same form in all places.

Remaining tasks

Reviews needed
Tests to be written or run
Needs testing on different browsers.
Documentation to be written / updated.
UI needs some attention to be nice.
UI auto change when switching displays.

User interface changes

The UI is changed for the block settings. This needs to be tested on different browsers.

Original report by Pepper

The Basic Toolbox, when selected for the Addthis Block, only shows the icons for facebook and twitter. It doesn't seem to take any of its settings from the configured services on the main addthis page, and it doesn't have the ability to write in services, separated by commas, like in the Content Type, Manage Display settings.

How can you tell it to add more icons for the block view? I'm not seeing a way so I'm reporting this as a bug.

CommentFileSizeAuthor
#15 1694868-block_settings.patch8.26 KBmatglas86
#8 addthis_custom_settings_toolbox_block-1694868-8.patch5.42 KBckrina
#5 addthis-block-settings.patch5.38 KBmogtofu33

Comments

nflowers1228’s picture

nflowers1228 commented

I had the same issue. I even added custom code in the field and still only 2 icons.

BioALIEN’s picture

BioALIEN commented

Using version 7.x-4.0-alpha1, you can add extra services via:
Home › Administration › Structure › Content types › [your content type] › Manage display

You can add any of the services listed by addthis. However, I haven't been able to add counters like the samples on the addthis.com get code page.

Pepper’s picture

Pepper commented

Yes, it works fine when attached to a content type, but you can't choose what services show up when you select the toolbox display in a block. And, it doesn't seem to go by the ones selected in the configuration, or if it does, only two of them show up.

cesabal’s picture

cesabal commented

Yes i have same problem when i want show in a block.... need add services

mogtofu33’s picture

mogtofu33 commented
Status: Active » Patch (to be ported)
StatusFileSize
new addthis-block-settings.patch5.38 KB

I got the same problem and currently it seems specific settings for block is not implemented.
Here is a patch file to add settings support on the block.

Regards.
Mog

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

Tried the patch against 7.x-4.0-alpha1 and worked fine. Thank you!

TelFiRE’s picture

TelFiRE commented

Excellent patch! Why is it not applied :(

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Version: 7.x-4.0-alpha1 » 7.x-4.0-alpha2
Category: bug » feature
StatusFileSize
new addthis_custom_settings_toolbox_block-1694868-8.patch5.42 KB

I've adapted the#5 patch for 7.x-4.0-alpha2. Tried it in clean and non clean Drupal installations and worked fine for me.
Hope it helps.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Patch (to be ported) » Needs review

Changing status to needs review.

soulston’s picture

soulston commented
Status: Needs review » Reviewed & tested by the community

Works for me and applies cleanly to 7.x-4.0-alpha2, not tried it against the latest dev which appears to be behind the alpha?

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Version: 7.x-4.0-alpha2 » 7.x-4.x-dev
Status: Reviewed & tested by the community » Needs review

Just tested 7.x-4.0-dev version too in a clean D7, and works fine for me. Anyway, other tests would be wellcome.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

I reviewed this as well. Seems to work fine.

plato1123’s picture

plato1123 commented

We should probably roll this into the 4.0 branch as a developer can waste a tremendous amount of time digging through all the different options screens, clearing caches, troubleshooting, only to find the module just doesn't work correctly.

edit: patch in #8 worked great for me, can we roll this into the module?

matglas86’s picture

matglas86 commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Implementing it like this is not an option unfortunatly. I know it works but...

AddThis implement display types dynamicly. So new display types can be added. With this implementation new implementations are not possible. I have been working on a config implementation in blocks that uses the same callback as field formatters. That is what we use to store display ttpe settings. But Ajax functionality is not working along. I have a development version in my github account.

https://github.com/matglas/addthis/tree/settings_form

All help is welcome on this. I know people dont use the module because of this.

matglas86’s picture

matglas86 commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 1694868-block_settings.patch8.26 KB

I had some help with this from jeroen.b and some more work on my part and have working example of how I want it implemented. Please check this patchout.

There is a downloadable version of the module too here.
https://github.com/matglas/addthis/archive/feature/block_settings.zip

matglas86’s picture

matglas86 commented
Related issues: +#1364848: Block basic toolbox displays Facebook and Twitter only
matglas86’s picture

matglas86 commented
Issue summary: View changes

Update the summary.

matglas86’s picture

matglas86 commented
Title: Toolbox Toolbox only shows two services in block - can't add services like you can on content type » Block only uses defaults from Display type Toolbox - can't add services like you can on content type

Changed title.

matglas86’s picture

matglas86 commented

If I don't receive feedback in the coming week I'm going to apply the patch and close the issue. I want to make some progress on the issues.

matglas86’s picture

matglas86 commented
Status: Needs review » Fixed

Fixed with latest patch in commit 839da

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.