The 'custom link class' and 'custom link rel attribute' fields are always visible, even though they have Form API #states that dictate when they should be hidden...

CommentFileSizeAuthor
#1 custom_link_class_always_visible-1695528-1.patch1015 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new custom_link_class_always_visible-1695528-1.patch1015 bytes

According to the documentation for drupal_process_states(), "all conditions must be met for the state to be applied."

Since the ':input[name="options[settings][image_link]"]' => array('value' => '') condition didn't seem to be doing anything, I removed it and now the 'custom link class' field is correctly hidden when 'Link image to' is set to 'None'. Same for 'custom link rel attribute'.

Attached patch working for me.

maciej.zgadzaj’s picture

maciej.zgadzaj commented
Status: Needs review » Fixed

No good - your patch fixes it for content type field configuration, but it still doesn't work on view field configuration (that's what the other condition is for). Fixed in the most recent dev release, just pushed to d.o.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.