The node options settings implemented through the nodeapi 'settings' op is incorrectly invoked. Only the type is passed on as a string, while the nodeapi hook expects a node object. Therefore the type property of the object is not possible to use in the hook, and it is impossible to set and content type options.

One way to fix it is to use $node as a typename inside the nodeapi settings op implementation, and the other way is to really pass an object. A patch for the second option is attached.

CommentFileSizeAuthor
#5 Drupal-fix-node-options-settings1.patch1.51 KBgábor hojtsy
Drupal-fix-node-options-settings.patch1.38 KBgábor hojtsy

Comments

Anonymous’s picture

(not verified) commented

+1 for this fix, but please change double-quotes to single-quotes before applying it... BTW: There was a duplicate with a similar (although slightly less elegant) patch.

dries’s picture

dries commented

According to the PHPdoc, a $type-string can be used. If I remember correctly, this used to work?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I don't know if it used to work or not, since the drupaldocs.org docs are also a bit behind in following the code (still writing about columns to add to the settings table for nodes). Either way, it is just a question of definition. If we allow type names to be used, then the phpdocs in the contrib/docs needs to be updated, and this bug needs a different fix.

dries’s picture

dries commented

I used to work: just check lines 298, 314 and 334 of node.module.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new Drupal-fix-node-options-settings1.patch1.51 KB

OK, attached a different patch, using the $node as type name in case of the settings operation.

dries’s picture

dries commented

Committed to HEAD.

Anonymous’s picture

(not verified) commented