Closed (fixed)
Project:
Nodewords: D6 Meta Tags
Version:
4.6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
8 Feb 2005 at 01:25 UTC
Updated:
13 Nov 2005 at 16:33 UTC
Jump to comment: Most recent file
Comments
Comment #1
stefano73 commentedFixed two bugs on the previous module, the attached file is updated.
Replace line 79 with the following code:
The function _node_metatags_delete() has a bug too, this is the updated code:
Comment #2
(not verified) commentedThats awesome thanks! (I couldn't get the other one to work in my theme)
Comment #3
mikeryanWell, I had some META ideas in mind and zeroed in on the nodewords module, then found this which was a step closer... Now I've got (almost) everything I want in meta tag management in the attached version of your module:
I made a couple of other tweaks to the module as written - replacing quotation marks with ", and expanding the keywords field (the recommendations I've seen generally suggest limits of 250 on description length and 1024 on keywords, although I personally would never go near that limit).
Feedback? It can certainly be a bit smarter in both the description and keyword generation, but the glaring omission at the moment is a UI for managing the translation table (we've all got phpMyAdmin for that, right?:-).
Comment #4
gábor hojtsyThe nodewords module released for 4.6 has some of these features: ie. it sets the meta keywords automatically. Expanding abbreviations is quite special and should not be handled by this module. (No I don't have phpmyadmin :). The glossary module has such lists, and so if you desire this feature, it might be a lot simpler to reuse that module and plug it into nodewords.
Comment #5
jbernat commentedHi. I'm new to Drupal and PHP. I just saved the node_metatags_1.module to the modules directory of my 4.6.0 installation and ran the SQL contained within to create the tables successfully.
Has anyone seen this message when using the node_metatags_1.module? This is not a Drupal 4.5/4.6 compatibility issue, it it? Looks like a PHP thing.
Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in d:\apache\ssr\modules\node_metatags.module on line 78
Also on lines 91, 107, 161, 166
What is the best way to fix this, other than enabling the deprecated feature in PHP.INI?
Thank you!
Jim
Comment #6
jbernat commentedThis appears to function OK and does not require the PHP.INI be modified to enable the deprecated use of the pass by reference mentioned in my earlier post.
I will attach the file. The old source line is commended with JMB2005521 and the revised line immediately follows.
Is this the proper way to fix the aforementioned error? If so, I hope others will find the modification useful.
I welcome any advice you may have to offer.
Thanks,
Jim
Comment #7
webseo commentedI tried your node_metatags.module and all went well until I tried to update all my pages with the bulk update function. I received several of these error messages:
Did I do something wrong? Or does this module not function correctly? I tried nodewords, but had the problem with duplicate keywords and the patch didn't fix that (sorry - off topic here).
Thanks!
martin
webseo
Comment #8
henk@sharewareblogs.com commentedI like this module, but it can not be used as it is, because it works on every page on the site, instead of just the pages where it is needed.
One effect is that all RSS feeds are broken.
Another effect is that many pages give an error (can not modify header).
I'm not experienced in drupal module development, so I don't know how this can be fixed.
But it sounds easy to me, as certain other modules have the capability to select on which pages they are active.
Can anyone help?
Comment #9
henk@sharewareblogs.com commentedNever mind my previous remark, I found the problem.
While copying node_metatags, somehow a space was inserted after the closing ?>, which caused the html output to start with a space right there.
Comment #10
Robrecht Jacques commentedI will check out this node_metatags module and maybe incorporate some of it's features in nodewords. AFAICS node_metatags differs from nodewords in following points:
I remember seeing a module for setting a seperate teaser ("excerpt"), different from the beginning of the body-text. I'll look into how that module works and whether things "just work" if both modules are enabled. If both modules don't work together well, I might add seperate "description" support to this module (I prefer not to do this though if I can avoid it).
Expandable aliases seems a bit special purpose to me. Also, there doesn't seem to be a gui for setting them. On the other hand, if no aliases are set, nothing happens I suppose.
I suppose the bulk update is related to these expandable aliases.
I also want to investigate whether "taxonomy" or "folksonomy (free tagging)" could be used to input the keywords.
Comment #11
druvision commentedHi Robrechtj,
On july 17, you wrote:
I want to comment that description is much different from teaser:
Hence, description must be a separate field.
We might ease the user's work by setting the teaser to be equal to the description, if no teaser was entered. But that contradicts the current implementation where the teaser is equal to the 1st paragraphs of the body text and might create certain incompatibilities.
Comment #12
Robrecht Jacques commentedI get your point levavie, or at least I think I do :-)
Would that be ok?
Comment #13
cmsn00b commentedThat sounds great. I think it would be quite helpful to have seperate metatags for "title," "keywords" and "description" for each node.
Comment #14
druvision commentedHi robert,
Yes, it is enough to set the description field as a separate field. That would be great.
Defaults are much lower priority. No harm is node if the SEO has to enter it himself.
All search-engines except Google use the keywords and description fields, so they are needed. They use them to test your integrity against the links from outside sites.
Also, please allow to enter an ABSTRACT meta tag. This tag, gives further advantage in the search engines.
SQL may be changed as follows:
Comment #15
Robrecht Jacques commentednodewords.module now has a seperate DESCRIPTION and ABSTRACT tag in CVS-HEAD.
The other feature of node_metatags.module (expandable aliases) will not be implemented.
Note that the "nodewords" table has changed! Please read "README.txt" carefully!
Note that this is a large amount of new code. Please test and see if you encounter any bugs. Please open a new issue if you do!!
Comment #16
(not verified) commentedComment #17
(not verified) commentedComment #18
kindafun commentedComment #19
Marc Bijl commentedHi,
In this topic I just read the last comment, which told me:
So I downloaded the module. But, both nodewords.mysql and README.TXT do not give the suggestion these files are up to date. I.e. no databasefiled for description, and nothing about it in the readme.
Technically I am not very skilled (a real newbie), so I might think wrong somewhere :-D
Cheers,
Marc
Comment #20
ron_mahon commentedYou need to look in the CVS section of downloads.
It a place where developers put thing so that testers and other brave people can find and test new code.
Ron
Comment #21
Marc Bijl commentedHi,
Indeed! I had some e-mail exchange with Robrecht Jacques, and found out what CVS means. Got the latest CVS release and it seems to be pretty promising so far!
Cheers,
Marc
Comment #22
(not verified) commentedComment #23
jbernat commentedIs the node_metatags module referenced in this post supported as an official contribution, or are these the only releases published?
jim.bernatowicz.net
Comment #24
Robrecht Jacques commentedAs far as i know, node_metatags.module is only available as the attachments to this issue. It is not available on the drupal CVS repository.
This issue dates from before I took maintenance of nodewords.module and I think most of the improvements of node_metatags.module has been incorporated into nodewords now. So tell me why you want this node_metatags.module, and maybe I will incorporate the features you want into nodewords.
BTW nodewords works in 4.6 too, so if that is the problem... then there is no problem :-)
Comment #25
jbernat commentedI see. I believe this is a non-issue, then. It has been some time since I have worked with either module, and just referred someone to the node_metatags module (which I was using sometime back.) I will also advise them to evaluate the nodewords module for their needs.
Thank you,
jim.bernatowicz.net