Closed (fixed)
Project:
NewsFlash
Version:
5.x-1.3
Component:
Miscellaneous
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
23 Aug 2007 at 12:42 UTC
Updated:
20 Jun 2008 at 01:02 UTC
Seem to be missing a css file. Template.php looks for a content.css on line 46
drupal_add_css(drupal_get_path('theme', 'newsflash') . '/content.css', 'theme')
Is there a missing file, or is that something left over from your conversion?
Comments
Comment #1
roopletheme commentedWe typically create a content.css file that contains our site-specific content CSS code. We use it, for example, on all of the demo sites. Our intent is that the theme supports use of the file but does not include the file itself. This way, our users can create their own content.css file unique to their site Then when they upgrade the version of the theme, their site-unique additions to the theme remain unaffected by the upgrade.
This feature (?) grew out of a discussion on our user forums. We're open to criticisms of this approach, alternative ideas, etc. But at this point in time, this is 'by design'.
Comment #2
roopletheme commentedDidn't mean to close this so soon. I'll leave it open for further discussion.
Comment #3
Mel55113 commentedI didn't notice that the theme looks for content.css; I like this idea.
Let me propose a slightly different solution:
1. Add a configuration option for the theme to name a site's "content.css" file. Thus the site administrator can choose a name specific to a site even if the theme is in /sites/all/themes/newsflash/...
2. The code that generates the drupal_add_css should check for the existence of this file and conditionally execute the drupal_add_css.
Mel
Comment #4
roopletheme commentedI've set the status of some other issues as duplicates of this one. In order to confuse as few people as possible, I'm changing the title of this issue back to the original text. I'm hoping to reduce duplicate issues, and your original title was more clear than the others.
I like your ideas of a user-specified content css file and the conditional inclusion based on the file's existence. We'll get that into the next release.
Comment #5
pcs305 commentedWhy don't you just ship a very basic sample content.css file to eliminate the messages and document the feature in the README file?
It is very handy to have this feature.
Thanks for the theme!
Ian
Comment #6
softtouch commentedYes, better include a default content.css.
Its annoying to have that errors all the time on many pages...
Why you don't just CHECK for the existence before trying to load it?
Comment #7
harry slaughterI think it would be smart to *not* generate errors by default. Typically people use contrib themes specifically because they do *not* want to develop a theme themselves. They are likely not even familiar with CSS.
I would suggest removing the reference to content.css. Customizations to contrib themes are typically done in style.css anyway.
Comment #8
eanx commentedI've been trying to troubleshoot why I was seeing so many "page not found" messages when the system looked for content.css
Was very happy to find this message chain and the indirect suggested correction.
I uploaded a blank text file labeled content.css into my Newflash themes directory and that seems to have fixed it. When I get past being a CSS newbie, perhaps I'll experiment with theming my content via this new file.
Thanks for all the hard work on this theme.
Comment #9
roopletheme commentedI believe that this is a good idea that I just implemented poorly in the current version of NewsFlash. The better solution is to add a theme option that allows the user to specify a local CSS file for inclusion in the theme. This is the approach that I've implemented in Beale Street, Tapestry, and the newest version of LiteJazz. I'll get this feature into an updated NewsFlash (along with some other badly needed upgrades and a D6 port) as soon as time permits.
Comment #10
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.