Currently the CAPTCHA administration links on forms 'enable a captcha here', 'edit captcha type' link to the general CAPTCHA settings page with additional highlighting (by using the CSS class 'error') of the selection box for the relevant form_id. This design has the following problems:

    It depends on the used theme. If the theme does not define a layout for the CSS class 'error', the relevant form_id will not be highlighted and the administrator will not see a difference between a normal CAPTCHA settings page, which makes it difficult to set/edit the captcha type for the form_id.

  • Using the 'error' class just for highlighting is bad style because there is no error.
  • The design might wrongly suggest to the administrator that all the presented settings (e.g. persistence, CAPTCHA description) are specifically for that form_id only, while these are general settings.

I'm responsible for this design but I was never really happy with it. Now I worked on an alternative which uses a separate page with just a selection box for choosing the CAPTCHA type for the form. I also added a link for the general settings page to the CAPTCHA administration links, which imitates the old behavior.
See attached patch.

Comments

soxofaan’s picture

StatusFileSize
new6.23 KB

updated patch against captcha.module version 1.42.2.24

BTW in my original post I hit submit instead of preview and Murphies Law stroke ;). The list should have been:

This design has the following problems:

  • It depends on the used theme. If the theme does not define a layout for the CSS class 'error', the relevant form_id will not be highlighted and the administrator will not see a difference between a normal CAPTCHA settings page, which makes it difficult to set/edit the captcha type for the form_id.
  • Using the 'error' class just for highlighting is bad style because there is no error.
  • The design might wrongly suggest to the administrator that all the presented settings (e.g. persistence, CAPTCHA description) are specifically for that form_id only, while these are general settings.
soxofaan’s picture

StatusFileSize
new7.04 KB

update of patch (against captcha.module v1.42.2.28)

robloach’s picture

Status: Needs review » Needs work

This patch needs a re-issue.

soxofaan’s picture

StatusFileSize
new6.99 KB

updated patch (against captcha.module version 1.42.2.30)

soxofaan’s picture

Status: Needs work » Needs review
robloach’s picture

Status: Needs review » Reviewed & tested by the community

Tested and seems good.

robloach’s picture

Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)