Write feature files for the list of all files attached to a given release at http://drupal.org/node/3060/release.

CommentFileSizeAuthor
#14 doobie-project-release-files-1698736-13.patch3.78 KBkssundar
#10 doobie-project-release-files-1698736-8.patch5.05 KBkssundar
#5 doobie-project-release-files-1698736-3.patch5.29 KBkssundar
#1 project-release-files-1698736-1.patch5.15 KBkssundar

Comments

kssundar’s picture

kssundar commented
Status: Active » Needs review
StatusFileSize
new project-release-files-1698736-1.patch5.15 KB

Feature created and needs review.

Attached is the patch file for the same

eliza411’s picture

eliza411 commented

This patch isn't applying for me.

error: patch failed: features/bootstrap/FeatureContext.php:54
error: features/bootstrap/FeatureContext.php: patch does not apply
Checking patch features/bootstrap/SubContext.php...
Checking patch features/drupalorg/project_release_files.feature...

I'll continue to investigate, as this may be error on my part and update when I have an idea why.

eliza411’s picture

eliza411 commented

It appears that the issue is caused by ^M at the end of several lines. This can be addressed either in your editor or in Git. I recommend adjusting the settings in your editor since on other projects, committers are less likely change their git setup.

There might be better resources on the topic, but http://lostechies.com/keithdahlby/2011/04/06/windows-git-tip-hide-carria... has some discussion. You'll need to research your particular editor to adjust the CRLF settings.

eliza411’s picture

eliza411 commented
Status: Needs review » Needs work

Setting to "needs work"

kssundar’s picture

kssundar commented
StatusFileSize
new doobie-project-release-files-1698736-3.patch5.29 KB

Attached is the updated one with some code cleanup and space cleanup.

kssundar’s picture

kssundar commented
Status: Needs work » Needs review
eliza411’s picture

eliza411 commented
Status: Needs review » Fixed

Please review and re-open as needed.

Committed in:
http://drupalcode.org/project/doobie.git/commit/aa8589d5

kssundar’s picture

kssundar commented
Status: Fixed » Needs work

Actually needs work.

Implement the step definition 'The md5 hash should match ""'

To compare the md5 hash of a file with the one provided in the above step definition, we have to store the md5 hash of the requested file temporarily. Can we use the "HackyDataRegistry" class to set and get variables?

eliza411’s picture

eliza411 commented

Thanks for re-opening. My understanding is that you should only need the HackyDataRegistry to pass a value between two different scenarios; otherwise, I believe it's best practice to locate the md5 hash earlier in the scenario and store it on the session object for use in a subsequent step.

I may, of course, be wrong,.

kssundar’s picture

kssundar commented
Status: Needs work » Needs review
StatusFileSize
new doobie-project-release-files-1698736-8.patch5.05 KB

Attached is the updated patch file.
Changes:
1. right_sidebar is now moved under 'layout'
2. implemented step definition to check the md5 hash of the project download

eliza411’s picture

eliza411 commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kssundar’s picture

kssundar commented
Status: Closed (fixed) » Needs work

I think this change is not committed. Could not find the required functions in the latest clone. Will roll out one more patch corresponding to the latest build.

kssundar’s picture

kssundar commented
StatusFileSize
new doobie-project-release-files-1698736-13.patch3.78 KB

Attached is the updated patch. Please review and commit.

kssundar’s picture

kssundar commented
Status: Needs work » Needs review

Changing status

eliza411’s picture

eliza411 commented
Status: Needs review » Needs work

I think the commit for a53634834 may have caused this not to apply. I hope sdboyer will be able to lend me a hand in better managing the patch workflow. Let's bring this up tomorrow during our call (which I may be able to make).

kssundar’s picture

kssundar commented

Committed to repo and can be seen here - http://drupalcode.org/project/doobie.git/commit/5694888

kssundar’s picture

kssundar commented
Component: Feature/Scenarios » Step definitions
Status: Needs work » Needs review

Actually needs review.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

Tests are currently failing, but I think it's because the git site currently has a 500 error at http://git6site.devdrupal.org/download, rather than anything wrong with this step definition.

Marking RTBC.

However, for future step-definitions (and many of the existing ones), check out the changes in commit f1ed2f5, where I cleaned up some of the comments to match the Drupal coding standards.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Fixed

Merged to master.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kssundar’s picture

kssundar commented
Version: » 7.x-1.x-dev
Component: Step definitions » Feature/Scenarios
Assigned: Unassigned » kssundar
Status: Closed (fixed) » Patch (to be ported)
Issue tags: +releases, +sprint 18

Need 7.x update

kssundar’s picture

kssundar commented
Status: Patch (to be ported) » Needs review

Added relevant tags - http://drupalcode.org/project/doobie.git/commit/c075fbb

eliza411’s picture

eliza411 commented
Status: Needs review » Reviewed & tested by the community

Looks fine. Tests are still failing because of the broken site and might need update when D7 Drupal.org is ready for feedback.

eliza411’s picture

eliza411 commented
Status: Reviewed & tested by the community » Closed (fixed)

Updated to match D7.