Enabling mailhide without setting keys [#170012]

If you enable mailhide and forget to set the keys, the first time mailhide is invoked, the library will die with an unfriendly error message. If, as happened to me when testing, an affected email address is on the site's front page, you can be entirely locked out and forced to disable the mailhide module directly from the database.

This patch checks the public and private keys before invoking the recaptcha library and fails gracefully if zero-length strings are detected.

Comment	File	Size	Author
	recaptcha-mailhide-die.patch	2.11 KB	kthagen

Comments

Comment #1

robloach

he/him

commented 24 August 2007 at 06:52

Assigned:

Unassigned

» robloach

Sounds great! Once I shift the keys into its own settings, I'll start work on this.

One note, empty is what you were looking for ;-) ...

if ($recaptcha_mailhide_public_key == '' || $recaptcha_mailhide_public_key == null || $recaptcha_mailhide_private_key == '' || $recaptcha_mailhide_private_key == null) {
// ... vs ...
if (empty($recaptcha_mailhide_public_key) || empty($recaptcha_mailhide_private_key)) {

I'll stick this in once the settings page is up.