in function apachesolr_search_run() we have:

  $process_response_callback = variable_get('apachesolr_search_process_response_callback', 'apachesolr_search_process_response');

This should be a search environment variable, not a variable that applies to all environments.

CommentFileSizeAuthor
#1 1700472-1.patch858 bytespwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 1700472-1.patch858 bytes

simple change - plus cleans up variable naming for better consistency.

pwolanin’s picture

pwolanin commented
Title: Make 'apachesolr_search_process_response_callback' an search environment variable » Make 'apachesolr_search_process_response_callback' a search environment variable
Status: Needs review » Fixed

committed to 7 and 6

cpliakas’s picture

cpliakas commented

Should there be an update function here to save the current "apachesolr_search_process_response_callback" variable as an environment variable to all environments? I played around with this with Solr Devel, and this change would have broken the module. This is an über-power user feature, but I wanted to raise the point just in case.

Thanks,
Chris

pwolanin’s picture

pwolanin commented

Well, it was added by Nick to play with result grouping - it wasn't even advertised in the API docs afaik, so my answer was "no" to needing an update.

cpliakas’s picture

cpliakas commented

I'll buy that. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.