RelationQuery should not force the range of results to return

I am very hesitant on committing this. As RelationQuery extends EntityFieldQuery if one is not satisfied with the 0, 50 range per default, it's easy to skip relation_query and just do a new RelationQuery and then call ->range.

It was not a long ago that I figured out that it was RelationQuery thas was setting the default range. Initially, as a coder, I quickly checked the RelationQuery class and thought it was just EFQ with the related method. So I agree with Brian here, the class extends EFQ and the added range default looks more like a personal preference that is likely to confuse many.

Hrm. What about a doxygen patch on relation_query then?

I don't think it's as much a problem with relation_query(). What if we move the range from class constructor to relation_query(patch does this)?

Please go ahead and commit this.

committed

This is not good yet.

Relation API uses relation_query() a lot, without taking care of results beyond 50. For example relation_entity_delete() does that, which means if any entity is part of over 50 relations only first 50 be checked for deletion. So either we remove range() from relation_query as well or convert all occurrences of relation_query to RelationQuery.

1. relation_rules_get_related_entities has a relation_query followed by relation_load_multiple. This should use a Rules option, defaulting to 50.
2. relation_ui_type_delete_confirm uses it for count. Yes, the range can be removed
3. relation_relation_exists definitely convert
4. relation_get_related_entity add a range of 1.
5. relation_entity_delete perhaps convert to batch?
6. relation_dummy_field_field_prepare_view loads them all. I vote on keeping the 50.

1. relation_rules_get_related_entities has a relation_query followed by relation_load_multiple. This should use a Rules option, defaulting to 50.

Where can I find that Rules option?

5. relation_entity_delete perhaps convert to batch?

I don't think it's possible to create a batch in hook.

This patch fixes other points

#1570510: relation_entity_delete() is unneccesarily destructive. is related issue and relation_entity_delete is being fixed there.

Committed, without relation_entity_delete improvements that is.

In troubleshooting why Search API was only loading 50 relations, I realized that the pseudo entity wrapper property for relations calls relation_rules_get_related_entities to load the related entities. This method has a hard limit of 50 as mentioned in above. @chx suggests that the 50 limit be passed as a default rules option (I'm guessing he means rules parameter).

There are three reasons I'm confused here:

1) relation_rules_get_related_entities is NOT defined as a rules action in hook_rules_action_info. Do we need to write an action to call this and have limit as a parameter?
2) If no, relation_rules_get_related_entities is only used to define properties of the entity in relation_entity_property_info_alter(), so why is it in the rules file?
3) If the 50 limit is for preventing potential memory/timeout issues, is the alter below the best way around this situation

/**
 * Implements hook_entity_query_alter().
 */
function MYMODULE_entity_query_alter(&$query) {
  if (!empty($query->entityConditions['entity_type']) && !empty($query->entityConditions['bundle']) && !empty($query->range)) {
    $entity_info = entity_get_info('relation');
    $bundles = array_keys($entity_info['bundles']);
    if ($query->entityConditions['entity_type']['value'] == 'relation' && in_array($query->entityConditions['bundle']['value'], $bundles)) {
      unset($query->range);
    }
  }
}

This issue was about RelationQuery and relation_query() (and over year old already). Please open a new issue with this.

Related #2259195: Rules integration and hard limit of 50 on relation_query

FYI: Icreated a follow up issue to fix a bug in the dummy field: #2501067: relation_dummy_field_field_prepare_view should not over write existing items