See #1696710: Revamp visual styling Product creation. for details.

We've agreed to do the following:

  • Remove the "No variations have been created. At least one variation is required." text. It is confusing and doesn't help people understand what is going on.
  • Remove the "Add new variation" text from initial adding - it creates two titles, very close to each other, making it harder to scan. It can still be there when there are other items, and you are creating another.

The styling in Kickstart will also be made more subtle (fieldset titles no longer have the big background, etc), so the default styling for the Seven theme should follow that as well.

CommentFileSizeAuthor
#4 1700554-combined.patch4.98 KBdudenhofer
#2 1700554-padding-fixes.patch2.03 KBdudenhofer
#1 1700554-first-try.patch4.24 KBbojanz

Comments

bojanz’s picture

bojanz commented
Status: Active » Needs review
StatusFileSize
new 1700554-first-try.patch4.24 KB

Initial patch.

dudenhofer’s picture

dudenhofer commented
StatusFileSize
new 1700554-padding-fixes.patch2.03 KB

See if this works for fixing some of the padding issues in seven.

bojanz’s picture

bojanz commented
Status: Needs review » Needs work

The patch doesn't apply when I have #1 applied.
Please roll a patch that includes both #1 and #2.

Also, 

 .ief-row-form {
-  border-bottom: 1px solid #ccc !important;
+  border-bottom: 10px solid #ccc !important;
 }

This looks accidental.

dudenhofer’s picture

dudenhofer commented
StatusFileSize
new 1700554-combined.patch4.98 KB

Sorry! hopefully this one works better. It should wrap them both together and include some minor changes from #2, including the moving the 10px border from .ief-row-form to .ief-row-form .ief-form-row in the inline_entity_form.css instead of the inline_entity_form.seven.css

Let me know if this one works better

bojanz’s picture

bojanz commented
Status: Needs work » Fixed

Not completely sure about the gray background for the "add variation" form, but let's see how the users react. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.