Nice work with this module! It seems efficient and clean. :-)

While browsing around in the code, I noticed that the name space used for the data table is bundle_hierarchy rather than bundle_inherit. I guess this is for historical reasons, but I also guess that it should change.

(I'm a bit hesitant to mark this as a bug, but it was the best category match.)

CommentFileSizeAuthor
#1 1701566-update_db_table_name.patch10.38 KBitangalo

Comments

itangalo’s picture

itangalo commented
Status: Active » Needs review
StatusFileSize
new 1701566-update_db_table_name.patch10.38 KB

Attached is a patch that changes the db table name to bundle_inherit, and also changes the alias used from 'bh' to 'bi'.
As a bonus, it also adds blank lines to all files (as per Drupal standard, to make it easier for version control).

There are no update hooks to change any existing data tables. :-(

alexweber’s picture

alexweber commented
Assigned: Unassigned » alexweber

Thanks for the patch Johan! I was just recently give co-maintainership by lemark and I'll take a look at this and hopefully commit it in preparation for a stable beta version!

alexweber’s picture

alexweber commented
Status: Needs review » Needs work

@itangalo, the patch needed a re-roll but since its 5am in Sweden I just did it myself! :)

Next step before committing this is getting an upgrade path working. If there's no clean API way of doing this we should just do it in a less clean way.

alexweber’s picture

alexweber commented
Status: Needs work » Fixed

Committed in 7d1e1d0.

I'm marking this as fixed and creating a separate issue for the upgrade path: #1721738: Create upgrade path for table name change

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.