Coder Module Review

Line 27: string concatenation should be formatted without a space separating the operators (dot .) and a quote

      return '<p>' . t('A captcha is a tool to fight automated spam submission of forms (e.g. user registration forms, comment forms, guestbook forms, etc.) by malicious users. A captcha is an extra field (or several fields) on a form presented to the user. It embodies a challenge, which should be easy for a normal human to solve (e.g. a simple math problem), but hard enough to keep automated scripts and spam bots out. Users with the \'skip captcha\' <a href="@perm">permission</a> won\'t be offered a captcha. Be sure to grant this permission to the trusted users (e.g. site administrators).', array('@perm' => url('admin/user/access'))) . '</p>';

Line 81: use a space between the closing parenthesis and the open bracket

function _captcha_available_challenge_types(){

Line 83: Control statements should have one space between the control keyword and opening parenthesis

  foreach(module_implements('captcha') as $module) {

Line 86: Control statements should have one space between the control keyword and opening parenthesis

      foreach($result as $challenge) {

Line 116: Arrays should be formatted with a space separating each element and assignment operator

        drupal_set_message(t('Disabled captcha for form %form_id.', array('%form_id'=>$form_id)));

Line 122: Arrays should be formatted with a space separating each element and assignment operator

        drupal_set_message(t('Deleted captcha for form %form_id.', array('%form_id'=>$form_id)));

Line 177: Arrays should be formatted with a space separating each element and assignment operator

      $form['captcha_types'][$captcha_point->form_id]['captcha_type']['#attributes'] = array('class'=>'error');

Line 258: Control statements should have one space between the control keyword and opening parenthesis

    if(!variable_get('captcha_persistence', TRUE) && ($_SESSION['captcha'][$form_id]['success'] === TRUE)) {

Line 278: Arrays should be formatted with a space separating each element and assignment operator

          array('%type' => $captcha_point->type, '%module' => $captcha_point->module, '%form_id'=> $form_id)),

Line 308: Functions should be called with no spaces between the function name

    $form['captcha']['captcha_solution'] = array (

Line 318: Functions should be called with no spaces between the function name

    $form['captcha']['captcha_token'] = array (

Line 453: Control statements should have one space between the control keyword and opening parenthesis

  foreach(element_children($form) as $key) {

Line 491: Control statements should have one space between the control keyword and opening parenthesis

    foreach(module_implements('captcha') as $module) {

Line 494: Control statements should have one space between the control keyword and opening parenthesis

        foreach($challenges as $challenge) {

Line 523: Control statements should have one space between the control keyword and opening parenthesis

  switch($op) {

Line 533: Functions should be called with no spaces between the function name

        $result['form']['captcha_response'] = array (


image_captcha.module
Include the CVS keyword $Id$ in each file
Line 19: string concatenation should be formatted without a space separating the operators (dot .) and a quote
      return '<p>' . t('The image captcha is the popular captcha type where a random text code is obfuscated in an image.') . '</p>';



Line 84: Control statements should have one space between the control keyword and opening parenthesis
  foreach($fontsdirectories as $fontsdirectory) {



Line 85: Control statements should have one space between the control keyword and opening parenthesis
    foreach(file_scan_directory($fontsdirectory, '\.[tT][tT][fF]$') as $filename => $font) {




Line 180: Control statements should have one space between the control keyword and opening parenthesis
  switch($op) {



text_captcha.module



Include the CVS keyword $Id$ in each file


Line 17: string concatenation should be formatted without a space separating the operators (dot .) and a quote
      return '<p>' . t('This text based captcha presents a captcha phrase of a given number of words and the visitor is asked to enter the n\'th word.') . '</p>';



Line 106: missing space after comma
  $o = mt_rand(0,1); // randomly start with vowel or consonants



Line 127: Control statements should have one space between the control keyword and opening parenthesis
    foreach($keys as $key) {



Line 134: missing space after comma
      $words[] = _text_captcha_generate_nonsense_word(mt_rand(3,7));




Line 159: Control statements should have one space between the control keyword and opening parenthesis
  switch($op) {



Line 172: Functions should be called with no spaces between the function name
        $result['form']['captcha_response'] = array (



Going by the Drupal coding standards is probably a good thing ;) .