As per the discussion at: http://lists.drupal.org/archives/drupal-devel/2005-02/msg00302.html (settings inconsistencies)

This patch implements the suggestions show in the screenshot (found in the link above).

It also adjusts a few coding convention inconsistencies that I have noticed (e.g. unnecissary passing of form [edit] data between functions)
Though more code could be cleaned in user module this was just a start to meet the primary goals of this patch.

Finally the help text found in hook_help are now linked properly with their associated pages, and links within the text now take you to the proper pages.

Dries: if you would like to test drive this on my demo site, contact me and I can set you up with an admin account.

Other testers are welcome.

andre

CommentFileSizeAuthor
user_module_1.patch10.64 KBandremolnar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andremolnar’s picture

Almost forgot,

The creation of the user/users path was done to allow the creation of a secondary local task for the user listing page.

admin/user
admin/user/users (default local task of admin/user - shows the list of users)
admin/user/users/create (child of the default task allowing you to add a user from the user listing page).

If the naming is troublesome, I'm open to suggestions to change it, but the format listed is required to create the menu parent-child relationships.

I also noticed that 'create' and 'add' are used in different modules throughout Drupal (both meaning and doing the same sort of thing). What is the standard? 'create' or 'add'? Since this is about consistancy, we might as well tackle this issue as well.

andre

Steven’s picture

-1 on moving roles. It is access control. I stick to my "users" = "people" idea: the only role thing that I think should go in to "users" is assigning users to rules. And that is already there due to editing accounts.

Setting up roles is not setting up users.

killes@www.drop.org’s picture

patch: **** malformed patch at line 132:

coreb’s picture

Version: x.y.z » 6.x-dev

Moving out of the x.y.z queue into 6.x-dev. I don't know if this is still needed.

webchick’s picture

Version: 6.x-dev » 5.x-dev
Status: Active » Fixed

I think the reworked admin panel in 5.x sufficiently addresses this issue.

Anonymous’s picture

Status: Fixed » Closed (fixed)