Write Feature File/s for drupal.org Create Project (create_project.feature)

We dug through documentation and found that you can set the file path as a parameter, but it must be a full path.

This needs some adjustment to use new steps:

You can now say:
When I fill in "Field" with random text which lets us run the test repeated

Given /^I updload the following "([^"]*)" <files>
needs some work. The spelling (upload) needs correction, but halstead has some suggestions, too, which have not yet been written.

Finally,
I am logged in as a is now I am logged in as and may need adjustment accordingly.

Just a few suggestions. Also these functions could probably be made cleaner using http://docs.behat.org/guides/2.definitions.html#step-execution-chaining.

+++ b/features/bootstrap/FeatureContext.php
@@ -98,6 +101,9 @@ class FeatureContext extends MinkContext {
+    if (isset($parameters['files_path'])) {
+      $this->file_path = $parameters['files_path'];
+    }

Throw an exception here if the files_path isn't set explaining how to correct the error.

+++ b/features/bootstrap/FeatureContext.php
@@ -1643,4 +1649,146 @@ class FeatureContext extends MinkContext {
+        $filefield_id 	= 'edit-field-project-images-{index}-upload';
+        // upload button id
+        $uploadbutton_id 	= 'edit-field-project-images-{index}-filefield-upload';
+        // upload response id
+        $responsebox_id	= 'edit-field-project-images-{index}-data-description';
+        // upload set wrapper
+        $wrapperbox_id 	= 'edit-field-project-images-{index}-ahah-wrapper';
+        // parameters to be filled in after upload finishes
+        $arr_postupload_params = array(
+          // in description
+          'description' => 'edit-field-project-images-{index}-data-description',
+          // al tag
+          'alt text' => 'edit-field-project-images-{index}-data-alt',
+        );
+        break;
+      // for Create Case Study image upload
+      case 'case study image':
+        $addmore_id = 'edit-field-images-field-images-add-more';
+        // upload field id
+        $filefield_id 	= 'edit-field-images-{index}-upload';
+        // upload button id
+        $uploadbutton_id 	= 'edit-field-images-{index}-filefield-upload';
+        // upload response id
+        $responsebox_id	= 'edit-field-images-{index}-data-description';
+        // upload set wrapper
+        $wrapperbox_id 	= 'edit-field-images-{index}-ahah-wrapper';

Tab characters should be removed.

+++ b/features/bootstrap/FeatureContext.php
@@ -1643,4 +1649,146 @@ class FeatureContext extends MinkContext {
+  public function iFillInProjectDescriptionWith($description)
+  {
+    $this->getSession()->getPage()->findById('edit-body')->setValue($description);
+  }

Does this need a custom function? Can it be filled out using the predefined mink statements?

This is regarding the feature file only, just a few changes. The structure seems basically solid but the labeling of the steps is not quite accurate.

+++ b/features/project/create_project.feature
@@ -0,0 +1,38 @@
+    Then I follow "Your Dashboard"
...
+    Then I should see the heading "Create Project"

This should read When I follow ...

+++ b/features/project/create_project.feature
@@ -0,0 +1,38 @@
+    Then I follow "Your Dashboard"
...
+    Then I follow "Project resources"

Again, this should be part of the When steps, and so should say And I follow.

+++ b/features/project/create_project.feature
@@ -0,0 +1,38 @@
+    Then I should see the heading "Create Project"

This should be deleted unless there's a critical reason for its presence here, such as if the next step can be accomplished even on a resulting page that doesn't have the Create project heading.

Each feature file really should have just one Given, one When, and one Then section.

+++ b/features/project/create_project.feature
@@ -0,0 +1,38 @@
+    And I check the project is created

This is the first "Then" step. As a then step, it might read more naturally as Then the project should be created.

This looks good and right, but can you tab out the tables (or convince me it's not worth it)? It helps a lot with future readability.

Not sure how I missed the feature block the first time. We need some kind of actual business value for these:

Feature:
  In order to test the functionalities of Create Project
  As an Authenticated User
  I should be able to Create a Project

Should be more like:

Feature: Create a project
   In order to share my code with the community
   As a git vetted user
   I need to be able to create a project

I'll have a checklist ready for tomorrow, and we should be able to spot these all in one sitting.

Git user can only create a sandbox. We should distinguish carefully which of these is intended in the feature and/or scenario descriptions.

I'd like some feedback from @sdboyer on this one. Normally a feature calls out a single system actor and all the scenarios revolve around that one user. There are definite exceptions to this, though, and checking a matrix of permissions for a feature seems like one of them.

In such a case, the feature file probably shouldn't be naming a particular Drupal role. I think a human role like as a contributor ... I suppose that's where you were headed with "authenticated user" although that implies *any* auth user, which isn't the case either.

http://drupalcode.org/project/doobie.git/blob/f362d2f:/features/project/...

Thoughts?

Updated the feature to match the scenarios: http://drupalcode.org/project/doobie.git/commit/15f9308

Ready for code review.

I'm seeing failures on a few scenarios in create_project.feature. Code for the step definitions looks good (I pushed a few tweaks to standards, plus added an exception where a radio button was occasionally not being found to avoid a fatal error).

Ok, I committed a bit of cleanup that removes the need to specify a file path in the yml directory. It also makes use of the constant DIRECTORY_SEPARATOR instead of having to check for the OS that is running.

Merged to master.

Need 7.x update

Modified step in 6.x to match existing definition. Committed 6.x here - http://drupalcode.org/project/doobie.git/commit/395f5be

But, still needs 7.x update

This looks great, thank you!