There are two minor issues with the above:

  • fonts_com_project and fonts_com_filter_choices variables are deleted in hook_disable() instead of hook_uninstall(); this is probably not a good idea as one often temporarily disables modules when trying to debug some problem, and having to enter settings again is a needless hassle;
  • on the other hand, fonts_com_token variable is not deleted at all.

A patch is on its way.

CommentFileSizeAuthor
#1 fontyourface-Fonts_com_uninstall_procedures-1703410-1.patch1015 bytesDrave Robber

Comments

Drave Robber’s picture

Drave Robber commented
Status: Active » Needs review
StatusFileSize
new fontyourface-Fonts_com_uninstall_procedures-1703410-1.patch1015 bytes

Here's the patch.

On a second thought (or rather second check), the former issue (variables being deleted in hook_disable()) is present also in fontdeck.install and typekit_api.install, so it might make sense to fix them all at once (if this should be fixed at all, of course).

In my quick testing of uninstall procedures, there was no leftover stuff other than fonts_com_token variable (which was why I jumped on fonts_com.install only).

sreynen’s picture

sreynen commented
Status: Needs review » Fixed

This is committed. If you want to make a patch for the other two, that's fine. If not, I'll try to remember to move those deletes next time I'm doing something in those files.

Drave Robber’s picture

Drave Robber commented

Followup: #1705778: Improve uninstall for Fontdeck and Typekit API

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.