In a recent checkin, Views has been changed to force the results array of a view to have numeric keys. Currently, EFQ returns the results array with the entity id as key. I suggest that this behavior be changed, because it will not longer have any use starting from the next Views release.

My suggestion is to add entity_id to each entity, just like entity_type is added now.

See http://drupalcode.org/project/views.git/commit/d00b08378197aa27e80567a1b...

CommentFileSizeAuthor
#1 efq_views-entity-id-1704612-1.patch1.35 KBJorrit

Comments

Jorrit’s picture

Jorrit commented
Status: Active » Needs review
StatusFileSize
new efq_views-entity-id-1704612-1.patch1.35 KB

Please see the patch.

chx’s picture

chx commented
Status: Needs review » Fixed

Thanks a lot for bringing the issue to my attention and fixing the query plugin. I committed this and also fixed the tests which used the keys of $views->result.

Jorrit’s picture

Jorrit commented

Thanks for giving the git attribution, that doesn't happen too often.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.