Posted by aliaric on July 30, 2012 at 1:56pm
2 followers
Jump to:
| Project: | Colorbox |
| Version: | 7.x-1.3 |
| Component: | Code |
| Category: | task |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
Maybe it's not a good idea to store colorbox attributes in code. For example I can use together CAPTCHA module. And it's making little mess with value like that in user_pass:
'height' => '150')
Thanks.
colorbox.module 375-382 lines
<?php
if (variable_get('colorbox_login_links', 0) == 2) {
if (variable_get('user_register', USER_REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL)) {
$items[] = l(t('Create new account'), 'colorbox/form/user_register_form', array('query' => array('width' => '300', 'height' => 'auto'), 'attributes' => array('title' => t('Create a new user account.'), 'class' => 'colorbox-load')));
}
$items[] = l(t('Request new password'), 'colorbox/form/user_pass', array('query' => array('width' => '300', 'height' => '150'), 'attributes' => array('title' => t('Request new password via e-mail.'), 'class' => 'colorbox-load')));
}
$form['links'] = array('#markup' => theme('item_list', array('items' => $items)));
}
?>
Comments
#1
#2
The attempt to support opening various forms in a Colorbox was in hindsight never a good idea. Form error handling and form redirects are complicated, a lot of code would be needed to do it correctly. The 7.x-2.x branch removes the form support from the Colorbox module.