The pcp.admin.inc and pcp.rules.inc files are set to always be included when the module loads. This defeats the primary purpose of creating separate include files, which should be to improve performance by minimizing the module's bootstrapping footprint.

These includes should be called only when necessary.

Comments

grasmash’s picture

grasmash commented
Status: Active » Fixed

Committed fix. files have been juggled around a bit to move all unnecessary code into includes.

cellar door’s picture

cellar door commented
Status: Fixed » Needs review

There was no update to the pcp.rules in the changes to the recent dev version so the pcp.rules.inc wasn't being included I added the following to the module (doesn't matter where):

function pcp_rules_file_info() {
  return array('includes/pcp.rules');
}

Flushed the caches a few times and now the rule is back.

grasmash’s picture

grasmash commented
Status: Needs review » Fixed

Ah, that was an oversight on my part. I forgot that if a module.rules file is in a subfolder, it won't be recognized by default. Updated and pushed to dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.