Closed (fixed)
Project:
Drupal.org BDD
Version:
6.x-1.x-dev
Component:
Step definitions
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
30 Jul 2012 at 16:46 UTC
Updated:
13 Dec 2012 at 11:04 UTC
Jump to comment: Most recent file
Comments
Comment #1
sachin2dhoni commentedComment #2
sachin2dhoni commentedAdded the patch for this feature.
Comment #3
sachin2dhoni commentedComment #4
lotyrin commented4 scenarios (4 failed)
50 steps (30 passed, 16 skipped, 4 failed)
Steps fail when searching for issues ("No issues match your criteria."):
Code style:
Comments should be at the same level of indentation as their code and should try to be full sentences with punctuation.
Comment #5
sachin2dhoni commentedSteps fail when searching for issues ("No issues match your criteria."):
[Suresh]: When I logged in as site user and i follow the link
http://git6site.devdrupal.org/project/issues/user
When I enter any text in "Search for" and I press enter then I could not find any results.I guess the search based on "Search for" is not working in git6site and when I run the same in durpal.org its working fine
Earlier I tested the same in git6site as well as in drupal.org and I could see the passed cases.
Is the contents of git6site same as drupal.org?
I have fixed the remaining corrections except the above issue.
Please check the updated patch.
Comment #6
sachin2dhoni commentedComment #7
senpai commentedWe might need to refresh the git6site with a new copy of the production database. How painful is this, and what customized stuff do we need to save or write down before we delete the existing git6site database?
Comment #8
senpai commentedWord on the street is that we can perform a restore of the git6site's database from the upstream production site using Jenkins. Please provide a list of the test users we'll need after the restore is done, their expected passwords, and their roles + perms, and we will make sure they are re-created as part of the restore script.
Incidentally, this will also be useful on the git7site. :)
Comment #9
sachin2dhoni commentedThe username/password and permissions for the test users are as below
admin test/AdminTest100 - has complete admin access
site user/SiteUser100 (has not agreed to terms of service)
git user/GitUser100 (has agreed to terms of services; is not vetted and so cannot create full projects)
git vetted/GitVettedUser100 user (can promote sandboxes and create new projects)
docs manager/DocsManager100 - can manage documents on the site (/documentation/manage)
Please create this ASAP as these affect our feature files while running on git6site.
Comment #10
sachin2dhoni commentedHigh Priority
Comment #11
kssundar commentedAn issue has been created for this here #1720134: Script the re-creation of all needed test user accounts and passwords for git6site
Comment #12
senpai commentedThis issue is now un-blocked again because the needed users and passwords have been manually re-created by @eliza411. Issue #1720134: Script the re-creation of all needed test user accounts and passwords for git6site will track the both the Jenkins scripting job for re-creating the users|passes after each git6site restore, and the discussion and documentation of what those test user accounts should be and what they are allowed to do and where they are published.
Patch #5 above still needs review.
Comment #13
eliza411 commentedPlease review the .feature file for the appropriate Given/When/Then structure. A few specific comments follow below ... there are many ways you can isolate the tests to follow that structure so it's hard to fix line-by-line. Let's talk about this one on the next scrum.
Background statements are executed before every scenario and intended to put the system in a known state; they should not contain Then statements.
Again, this is a "Then" style statement. You don't need to look for the link, then follow it. You should just follow it. If it's not present, an exception will be thrown.
Comment #14
eliza411 commentedI've closed an earlier duplicate issue, #1570012: Views - Your Issues tab on user page. Would you please review it and ensure any good ideas for test coverage are included here.
Comment #15
sachin2dhoni commentedModified the scenario with appropriate Given/When/Then structure.
Uploading the patch for this feature.
Comment #16
eliza411 commentedThis test needs data set up in the Given statement to be reliable. I've added this issue to the meta issue: #1742962: [meta] Create data for tests
In the meantime, please review this for all of the items on the checklist. There's a draft of it at https://docs.google.com/document/d/1wPwWj8aTKmQtDwinZXlgpAdQQUiaEVYNseuP...
It's fine to commit it to the dev branch now that we have one, too.
Comment #17
sachin2dhoni commentedPostponing for now ,will resume with changes if any required for #1742962: [meta] Create data for tests
Comment #18
sachin2dhoni commentedTagging
Comment #19
eliza411 commentedSince we're going to be setting up data in the Given statements, let's revist this and see what can be done.
Comment #20
sachin2dhoni commentedTagging
Comment #21
sachin2dhoni commentedAs more steps are required to create test data, adding them in Given will make it bulky, I think. So I have Added a separate scenario to achieve it.
Uploading to the dev branch.
c7e4214
Please review it.
Comment #22
eliza411 commentedThe problem with creating the data in a scenario is that we can't guarantee that scenarios will run in order, so all the subsequent scenarios will fail.
Try running bin/behat features/drupalorg/project_issues_user.feature:35 for example.
To remove bulk, a master step definition that chains each of the smaller steps is a possible solution.
This also needs review for formatting standards ... did this get internal review?
I tagged the dependent scenarios.
Comment #23
eliza411 commentedSetting to needs work.
Comment #24
sachin2dhoni commentedUpdated to dev branch with fixes.
Please check the commit log: d9916f3
Comment #25
sachin2dhoni commentedComment #26
eliza411 commentedReady for code review ...
Comment #27
eliza411 commentedmerged to master
Comment #28
sachin2dhoni commentedRenamed the files from project_issues_user.feature to your_issues.feature
Please check the commit log for reference.2205a14
Comment #30
pradeeprkara commentedThe feature has been modified further and follow up #1846682: Update user_your_issues.feature for updates.