I found this option "Notify poster of own posts" is for "posts" only, if I'm the author of a post and I subscribe it (for comments). Is it possible to filter comments by me ? Because I just need to know somebody leave a comment on my post but I don't need a email of the comment by me.

Comments

salvis’s picture

Version: 5.x-1.9 »

I'd like to see this as well.

However, it's unlikely that new features will be implemented for 1.x, so I'm changing the feature request to 2.x, ok?

Please note that 5.x-2.x-dev is still under heavy development, so don't install it on a production site.

dennys’s picture

2.x is great, thanks for your support. And I'm still use 1.9 in production, I have a testing environment, please let me know if you need somebody to test the new functions.

salvis’s picture

Version: » 5.x-2.0-beta6
Status: Active » Fixed

The latest beta version should do just that. We'd appreciate your testing!

dennys’s picture

Version: 5.x-2.0-beta6 » 5.x-2.0-beta7
Status: Fixed » Active

Sorry, it seems not working. This is my test result for 2.0beta7, you can try it from http://drupal5.no-ip.org/?q=node/1 (This is Drupal 5.5)

Test 1:
I upgraded a test site from subscription 1.9 to 2.0 beta 7, and when I added a new comment, I saw this message in watchdog.

Column 'send_comments' in where clause is ambiguous query: INSERT INTO subscriptions_queue (uid, name, mail, language, module, field, value, author_uid, send_interval, digest, last_sent, load_function, load_args) SELECT u.uid, u.name, u.mail, u.language, s.module, s.field, s.value, s.author_uid, s.send_interval, su.digest, su.last_sent, 'subscriptions_content_comment_load', '12' FROM subscriptions s INNER JOIN subscriptions_user su ON s.recipient_uid = su.uid INNER JOIN users u USING(uid) WHERE s.module = 'node' AND s.field = 'type' AND s.author_uid IN (0, -1) AND send_comments = 1 AND s.value = 'blog' AND s.recipient_uid != 0 in D:\00www\WWW\main\includes\database.mysql.inc on line 172.

Test 2:
I installed 2.0 beta7 in another testing site (without 1.9), when I enabled it, I saw this message
user warning: Unknown column 'DRUPAL_AUTHENTICATED_RID' in 'field list' query: INSERT INTO dr_subscriptions_user (uid, digest, send_interval, send_updates, send_comments) VALUES(-DRUPAL_AUTHENTICATED_RID, 0, 1, 0, 0) in D:\00www\WWW\main\includes\database.mysql.inc on line 172.

Then I use anonymous account and admin account to post a comment and get this warning message: (The same as test 1)

user warning: Column 'send_comments' in where clause is ambiguous query: INSERT INTO dr_subscriptions_queue (uid, name, mail, language, module, field, value, author_uid, send_interval, digest, last_sent, load_function, load_args) SELECT u.uid, u.name, u.mail, u.language, s.module, s.field, s.value, s.author_uid, s.send_interval, su.digest, su.last_sent, 'subscriptions_content_comment_load', '1' FROM dr_subscriptions s INNER JOIN dr_subscriptions_user su ON s.recipient_uid = su.uid INNER JOIN dr_users u USING(uid) WHERE s.module = 'node' AND s.field = 'nid' AND s.author_uid IN (0, -1) AND send_comments = 1 AND s.value = '1' AND s.recipient_uid != 0 in D:\00www\WWW\main\includes\database.mysql.inc on line 172. 
salvis’s picture

Title: Don't send the subscriber his own comment » "Unknown column 'DRUPAL_AUTHENTICATED_RID'" on new install
Status: Active » Reviewed & tested by the community
StatusFileSize
new687 bytes

Thank you for your feedback!

For #1 see http://drupal.org/node/204765.

#2 (new install) here's the patch -- apply the patch, disable, uninstall, and reinstall, then it will work.

dennys’s picture

I patch the 2 patched but still got 3 error messages in watchdog when I add a new comment (upgrade and new install), but I'm not sure this is due to subscription module because these error messages are in node.module and database.mysql.inc. Do you have any suggestion for it? thanks.

    * warning: Invalid argument supplied for foreach() in D:\00www\WWW\main\modules\node\node.module on line 521.
    * warning: implode() [function.implode]: Bad arguments. in D:\00www\WWW\main\modules\node\node.module on line 525.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM dr_node n INNER JOIN dr_users u ON u.uid = n.uid INNER JOIN dr_node_revisions r ON r.vid = n.vid WHERE in D:\00www\WWW\main\includes\database.mysql.inc on line 172.
salvis’s picture

All three messages come from one call to node_load() with a bad parameter. I can't see this here though.

Can anyone else confirm or deny seeing it with BETA7?

dennys’s picture

StatusFileSize
new24.37 KB

I got the problem, when I disabled Comment Notify module, it's ok now.

There is only one successful message "Comment: added test 1." in watchdog now. But I still doesn't receive the mail.

1. I enabled all subscription modules including mail editor 1.1 but I didn't change any configuration of it.
2. For mail module, I use SMTP, it's ok for 1.9 and I can send a test mail from it now.
3. For subscription module, I enabled "Display watchdog entries for successful mailings". For the subscribe option of a post, please see the attachment.

salvis’s picture

Has cron run yet? Subscriptions 2.0 runs only on cron...

dennys’s picture

Yes, it's ok now. After the cron, the mails are sent.

salvis’s picture

Great, thanks!

You can also run cron manually from the status page, to make testing less cumbersome.

salvis’s picture

Committed to cvs, will mark it fixed when BETA8 is out.

dennys’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Thanks for your support, I think this issue could be closed.

salvis’s picture

Status: Closed (fixed) » Reviewed & tested by the community

No, let's keep it open, so that those who try BETA7 and encounter the issue can find it in the queue. I'll mark it "fixed" for BETA8 as soon as BETA8 is here.

azadi’s picture

I already download drupal 5.5,but i don't know how to install and run it.
HELP ME!!!!

salvis’s picture

I don't know how you got here -- the proper way to get started is by clicking on the "Handbook" link at the top of every page on drupal.org, which will lead you to http://drupal.org/handbooks. There you'll find "Getting Started". Work through the instructions there, and if you get stuck, then click on the "Support" link at the top.

Mojah’s picture

This patch works fine. Thank you.

salvis’s picture

Version: 5.x-2.0-beta7 » 5.x-2.0-beta8
Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.