Download & Extend
Better Formats » Issues

Strange blank border under the element with enabled better formats

Posted by klattring on July 31, 2012 at 6:23am
Project:Better Formats
Version:7.x-1.0-beta1
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

Strange blank border under the element with enabled better formats

AttachmentSize
blank_border.png5.27 KB
Login or register to post comments

Comments

#1

Posted by Tom Robert on August 8, 2012 at 3:57pm

This patch removes the entire filter wrapper when there are no permissions set for format, guidelines and help .

AttachmentSize
better_formats_remove_filter_wrapper-1706130.patch 543 bytes

#2

Posted by Tom Robert on August 9, 2012 at 8:44am
Status:active» needs review

#3

Posted by klattring on September 7, 2012 at 7:37am
Status:needs review» fixed

#4

Posted by mansspams on September 17, 2012 at 5:12pm
Status:fixed» reviewed & tested by the community

It will be fixed, once committed by maintainer. Ill set current status to RTBC since patch looks sane and fixes issue.

#5

Posted by jenlampton on November 10, 2012 at 12:24am

There is a fix mentioned here which may make this patch unnecessary: #934976: Provide method to hide input format fields without disabling WYSIWYG

#6

Posted by jenlampton on November 10, 2012 at 3:26am
Status:reviewed & tested by the community» needs review

I'm guessing at the fix mentioned from that other issue, but I believe this is the recommended change. Plus, it should also work with the change to WYSIWYG module. I have both patched versions of modules working together on my site.

AttachmentSize
better_formats-remove_filter_wrapper-1706130-6.patch 640 bytes

#7

Posted by Babymaggie on December 4, 2012 at 4:15pm

Not meaning to upset anyone, and it's probably my error, but after looking at the two patches on this page and trying them (by manually updating the better_formats.module file as I do'nt understand GIT) they both seem to break the wysiwig and prevent it from loading for the authenticated user.

I'm using 7.x-1.0-beta1 version.

Could someone please upload an already patched version for me to try?

Or should I try version 7.x-1.x-dev?

Best wishes

#8

Posted by jenlampton on December 17, 2012 at 10:19pm

@Babymaggie if you see a patch in the queue like this that is marked "needs review" then it will not be in the -dev version. Patches only make it into the -dev version once they are marked "fixed" and have been committed by the maintainer.

Are you familiar with the command line at all? You don't need to know GIT in order to apply a patch. You can download the patch file into the directory for the module that you are patching, and patch directly from there. here's what I do

cd MyDrupalSite/sites/all/modules/contrib/better_formats
wget http://drupal.org/files/better_formats-remove_filter_wrapper-1706130-6.patch
patch -p1 < better_formats-remove_filter_wrapper-1706130-6.patch

if patch asks you which file to patch you can just tell it better_formats.module.

Then rm the patch file

rm better_formats-remove_filter_wrapper-1706130-6.patch

Hope that helps :)

#9

Posted by Babymaggie on December 22, 2012 at 10:28am

Thanks for the step by step guide jenlampton - This is going to be very useful information to me. Thank you :)

nobody click here