How can I add an argument?

I have similar prolem - nothing changes.

I enabled the module, enabled pro-con for a certain node type but nothing changes in the links line of nodes (as I understand should happen from browsing procon.module. I added an argument in an indirect way (node/xx/add/procon-argument to a parent node but the argument doesn't show at the bottom of the node like arguments do.

Is Comment read/write should be anabled for a node to have arguments? Is there something else I should do that I am missing?

Documentation/README is obviously missing, even a basic one to get this working...

Yep, I should probably add some documentation since this seems hard. Look for "comment and argument settings" on the node edit page.

I found the argument settings for the underlying content type in the dit page and enabled the arguments but as stated above, nothing shows up...

I've got a large site and I've tried EVERY intuitive combination to get this working on MANY different types, all to no avail!

So my conclusion is that without documentation, instructing mere mortals like myself how to configure it, this is nothing but a great idea not actually an implementation.

-- Ade Atobatele

I did some changes to the code generating the arguments and the "add argument" link. I actually tested the version before that and I definitely had an add argument link. Anyway, please test the latest dev release (2007/09/27). Make sure you test it on a clean Drupal 5.2 (no contributed modules except Views, default theme Garland).

(Why do I need it for a clean Drupal deploymet? I am testing it on an active deployment (5.1))

Installed the new version, followed the new instructions in INSTALL.txt but... nothing changed - no add argument link in the inline links line and no arguments posted at the bottom of the node.

A clue to solve the bug might be that there is no "Enable Pros and Cons
arguments" under "Comment settings" when creating a new content item (while ther is indeed a such in the content type edit panel)

Sorry guys, I've tested this on a completely clean installation of Drupal 5.2 (that's the only way to know no other contrib modules are interfering with this module).
1. Created user 1.
2. Enabled views and procon.
3. Created a page and checked Enable Pros and Cons arguments under Comment and argument settings.
4. The link appears.

Let me know if you find any additional info that can shred some light on this, but until then I'm marking this as fixed, since this is all support I can give on this.

OK, I found the misterious problem!

It's the order in which modules' hook_form_alter (and other hooks) are invoked, i.e. the module weights. I found out that in the deployments where there is a problem, the procon hooks are invoked before the comment hooks.

procon_form_alter relies on being invoked AFTER comment_form_alter is invoked (e.g. lines 146-150 that override comment module's node form values). In such a case procon.install must specifically set the procon module weight to be greater than the comment module weight. This is achieved by adding the following to procon.install:

$comment_weight = db_result(db_query("SELECT weight FROM {system} WHERE name = 'comment'"));
      // make procon execute after comment:
      db_query('UPDATE {system} SET weight = %d+1 WHERE name = "procon"', $comment_weight);

In most deployments, it worked OK without the above addition to procon.install as the default weights of both procon and comment are 0 and then the order is determined alphabetically and so comment happens to come before procon. But some admins modify the weights in the system table or by using the Module Weight module. Moreover, due to a severe bug in RSVP module (rsvp.install increases by mistake the weights of all modules in system, see issue in http://drupal.org/node/179241) the weight of comment module was increased to 1 when RSVP module was installed and then when procon was installed afterwards its weight was zero - lower than comment module's increased weight. I suspect that all those who complained here had the RSVP installed and thus their comment module weight corrupted.

BTW, all those who already have procon installed and encounter the problem, simply change the weight of procon entry in the "system" table in the database to 2 (using phpMyAdmin or by using the Module Weight module which allows you to change module weights from the admin panels).

Thanks ekrispin for finding out the root of this problem. For the time being I will not adress this in procon since it seems to be caused of a bug in another module (RSVP), but if this keep causing problem in other situations I will of course look at the issue again. Many thanks again.

Hey fajerstarter,

You are the one who deserves the thanks for sharing this beautiful module!

I think that regardless of the underlying specific cause, the above addition in the install file is a common practice when a module logic relies on being invoked before/after a certain other module. It will save you a lot of possible issues here... Up to your decision...