To reproduce:
- navigate to admin/appearance/fontyourface/browse/fonts_com;
- select any filter that is likely to have several pages of results (e.g. Language: Cyrillic or Free or Paid: Free);
- navigate to page 2 (or whatever).
This results in:
Notice: Undefined index: op in fonts_com_browse_form() (line 985 of ../modules/fontyourface/modules/fonts_com/fonts_com.module).

CommentFileSizeAuthor
#2 fontyourface-Fix_notice_Undefined_index_op_in_fonts_com_browse_form-1706320-2.patch998 bytesDrave Robber

Comments

Drave Robber’s picture

Drave Robber commented

Potentially related issue: an attempt to click 'Reset' while something is typed into 'Name' field (but not applied) results in:

An AJAX HTTP request terminated abnormally.
Debugging information follows.
Path: /system/ajax
StatusText: 
ResponseText: 
ReadyState: 4

(update: does not seem so much related anymore)

Drave Robber’s picture

Drave Robber commented
Title: Notice: Undefined index: op in fonts_com_browse_form() » Fix notice: Undefined index: op in fonts_com_browse_form()
Status: Active » Needs review
StatusFileSize
new fontyourface-Fix_notice_Undefined_index_op_in_fonts_com_browse_form-1706320-2.patch998 bytes

Patch for #0 attached.

I tried to streamline the logic a bit but ran into some mysterious regression, so let's keep it simple.

On a side note, I couldn't get to the cause of #1 - maybe that should be a separate issue.

Drave Robber’s picture

Drave Robber commented
Assigned: Drave Robber » Unassigned

Unassigning - not supposed to review own patches.

sreynen’s picture

sreynen commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.