Hi,

I just discovered (rather painfully) that when using this module in conjunction with the Sasson base theme (i'm on the lastest release - version 7.x-2.5), if you put Sasson into development mode then respondjs fails. Note that i have CSS aggregation switched on.

I'm not entirely sure why, but putting Sasson into dev mode enables FireSass support (https://addons.mozilla.org/en-US/firefox/addon/firesass-for-firebug/) which i believe injects special comments into the CSS, and perhaps its tripping up on this.

Would you consider creating a warning for this, that will detect if Sasson is present and dev mode is on and warn that respondjs will not work?

Thanks

Comments

rupl’s picture

rupl
he/him
Primary language English
commented

I realize I have the warning for CSS aggregation, but that's for a known issue with core itself which will affect 100% of users. I'm hesitant to hardcode warnings into the module for every piece of contrib that doesn't play well.

I'd be happy to add a "Known Issues" section to the project page and README. How does that sound?

rich.3po’s picture

rich.3po commented

Sounds good, my concern is just that other people might try out this module (which is really useful btw) and incorrectly conclude that it doesn't work

Cheers

rupl’s picture

rupl
he/him
Primary language English
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Component: Code » Documentation
Status: Active » Fixed

Committed: http://drupalcode.org/project/respondjs.git/commitdiff/9ecd2f6

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rupl’s picture

rupl
he/him
Primary language English
commented
Title: Conflict with Sasson base theme development mode » Document a conflict with Sasson base theme development mode

Updating title for clarity when referencing issue in 7.x-1.2 release notes.