On drupal.org D7 test sites when viewing an Issue page, we are seeing this PHP warning from this module:

Warning: Invalid argument supplied for foreach() in dereference_list_allowed_list_values() (line 15 of /var/www/dev/project-drupal_7.redesign.devdrupal.org/htdocs/sites/all/modules/dereference_list/dereference_list.module).

I'll see if I can make a patch.

CommentFileSizeAuthor
#1 1706734-php-warning.patch870 bytesjhodgdon

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
Status: Active » Needs review
StatusFileSize
new 1706734-php-warning.patch870 bytes

Well, here's a patch that at least gets rid of the warning. But I'm not sure the module is working correctly.

Sorry, it's a bzr diff, since that is what's running on the dev sites. You should be able to apply it with patch -p4 or manually (small patch).

senpai’s picture

senpai commented
Assigned: Unassigned » bdragon
Issue tags: +sprint 7

Assigning to @bdragon for a review + commush.

bdragon’s picture

bdragon commented

Err, ignore this, I accidentally pasted some migration code I was working on into the wrong tab. :D

sheldonkreger’s picture

sheldonkreger commented
Assigned: bdragon » sheldonkreger

I'll be reviewing today.

sheldonkreger’s picture

sheldonkreger commented

Ran out of time today. I will take a look this weekend at the PNWDS.

sheldonkreger’s picture

sheldonkreger commented

It might just be the dev site I'm working with, but I don't see any warning when I visit issue pages. I tried viewing some of the nodes listed at project/issues as anon and as user 1 but could not replicate this issue.

senpai’s picture

senpai commented
Status: Needs review » Fixed

I just attempted to replicate this PHP warning on our git7site canonical staging server, and I cannot, so I'm closing this one as 'fixed'. Thanks @sheldonkreger and @jhodgdon!

Automatically closed -- issue fixed for 2 weeks with no activity.