This may overlap with some other tests, but in this case we should be checking that a newly create sandbox, sandbox that has been promoted to a project, and project are all appearing properly

Project tab - Project tab should NOT appear for anyone but the auth user
Project tab - Project tab should appear for the user
Commit numbers - Verify commit numbers are lower than in d.o.
Project list - Sandbox project should appear
Projects links - Project links lead to the main project page
SSH Keys tab - Verify tab exists

Comments

pradeeprkara’s picture

Issue tags: +sprint 3

tagging for sprint 3

sachin2dhoni’s picture

Assigned: Unassigned » sachin2dhoni
sachin2dhoni’s picture

Status: Active » Needs review

Page considered: http://drupal.org/user (After login)

I have a few questions as below:

Project tab - Project tab should NOT appear for anyone but the auth user
[Suresh]: We assume "Project" is not a tab but a heading/section below the page.

Commit numbers - Verify comment numbers are lower than in d.o.
[Suresh]: Currently when i login as 'site user' or 'git user' or other users, i do not find any data for "Projects". We created a project as 'site user' but were not successful in creating a repository. We followed the instructions from here - http://git6site.devdrupal.org/project/1668843/git-instructions and are getting "Permission denied" message when we try to push or pull.

Please provide us an account that has commits done or help us create a project/repo so that we can do some commits and we will be able to see the commit numbers on the profile page.

Project list - Sandbox project should appear
Projects links - Project links lead to the main project page
[Suresh]: Depends on the above point.

eliza411’s picture

The only help available until I am back (for creating repos) is in the features/git/repo.feature file and its steps and it's not solidly implemented.

Site user should NOT be able to create a project (has not agreed to terms of service)

Check that git user has agreed to terms and that git vetted has as well. They should be able to push.

Feel free to postpone this issue until the next sprint as creating repos isn't easy.

kssundar’s picture

To test items 3, 4 and 5, we need either of the below two:

1. a project and git repository should be created by 'git user'
2. A user credentials who has already created a project, repo and has done some commits

If its difficult to create a project and repo, then we can go for option 2.

Please suggest.

kssundar’s picture

Issue summary: View changes

clarifying need for creation of new data

eliza411’s picture

Assigned: sachin2dhoni » eliza411
Status: Needs review » Needs work

I'm going to assign this to me to get set up as there are a lot of sticky git creation issues that I need to look into. I'll assign it back when I can give you enough information to work with.

pradeeprkara’s picture

Issue tags: +sprint 4

tagging for sprint 4

eliza411’s picture

Assigned: eliza411 » kssundar

We have all the git things worked out in repos.feature (or as close as we're likely to get for a while), so I'm assigning this back.

kssundar’s picture

Status: Needs work » Needs review

Taking this one and plan is as below;

The scenarios will:
1. create a project
2. create repository
3. do a couple of commits
4. verify commit numbers and project titles in profile page

Please correct me if there needs to be any change.

kssundar’s picture

eliza411’s picture

Assigned: eliza411 » Unassigned
Status: Needs review » Needs work

The plan looks solid to me. #1743082: Verify Maintainers tab and its permissions (project_maintainers_tab.feature, edit, vcs, maintainers, issues, releases) needs to delete the repo it creates when it is done, but that's already noted over there.

kssundar’s picture

Assigned: Unassigned » kssundar
Issue tags: +sprint 7

tagging

kssundar’s picture

Assigned: kssundar » eliza411
Status: Needs work » Needs review
eliza411’s picture

Status: Needs review » Needs work

Similar feedback on given/when/then to http://drupal.org/node/1706768#comment-6449432

kssundar’s picture

Status: Needs work » Needs review
Issue tags: +sprint 8

Updated feature and step definitinos according to the suggestions.

http://drupalcode.org/project/doobie.git/commit/80e72ef

eliza411’s picture

Component: Feature/Scenarios » Step definitions
Assigned: eliza411 » Unassigned

Looks good to me, moving forward for code review.

A note about dependent scenarios: As far as tizzo and I have been able to work out, we're stuck with dependent scenarios within a feature file; let's continue to tag them as such but as long as they don't cross into dependencies on other feature files, we should be okay.

jhedstrom’s picture

Status: Needs review » Reviewed & tested by the community

Code changes look good.

eliza411’s picture

Status: Reviewed & tested by the community » Fixed

merged to master

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

edited Commit numbers - Verify comment numbers are lower than in d.o. to Commit numbers - Verify commit numbers are lower than in d.o.