Tab list - Tab list includes: Account - Drupal - Personal info - Work - Newsletters and Email Addresses
Account Git access - Git access checkbox exists. Changing checkbox status remains.
Account Git access - Verify with "disabled" Git access , Write to VCS is disabled in projects you own (check both the permission and a git push)

Comments

sachin2dhoni’s picture

sachin2dhoni commented
Assigned: Unassigned » sachin2dhoni
Issue tags: +sprint 7

Taking this up

sachin2dhoni’s picture

sachin2dhoni commented
Issue tags: +sprint 8
sachin2dhoni’s picture

sachin2dhoni commented
Status: Active » Needs review

Uploaded the feature to dev branch.

Please check the commit log:6aad773

The test is in "git vetted user" login. As the git vetted user already have git access, I am following the steps in the feature as
Step 1:
Firstly creating the sandbox project and initialize repo (as git vetted user already have git access)
Step 2:Disagree to git access agreement
Step 3: Then Clone repo and push to repo as non-git user
Step 4: Resetting original git access agreement for not affecting other features as they are dependent on git vetted user.

Please review it.

eliza411’s picture

eliza411 commented
Status: Needs review » Needs work

I'm getting some consistent failures on this: 

    And I clone the repo                                         # FeatureContext::iCloneTheRepo()
      The clone did not workspawn git clone --recursive --branch master ssh://gitvetteduser@git6.devdrupal.org:2020/sandbox/gitvetteduser/1780918.git ambcxo2fqxwznj7r
      Cloning into 'ambcxo2fqxwznj7r'...
      gitvetteduser@git6.devdrupal.org's password: 
      Permission denied, please try again.
      gitvetteduser@git6.devdrupal.org's password: 
    Then I should not be able to push a commit to the repository # FeatureContext::iShouldNotBeAbleToPushACommitToTheRepository()

I manually logged in as git vetted user in order to verify my behat.local.yml had the proper password and it does, so something else seems to be up.

I'm also concerned that if we use git vetted user for this test and a step fails after the scenario in which the terms of agreement is unchecked, then we'll have tests failing for quite confusing reasons. I think git vetted user should *stay* vetted.

sdboyer created a user called 'git disabled' which is created before each new database dump. That user is fair game for a test like this, but it begins in the disabled state and must be enabled.

sachin2dhoni’s picture

sachin2dhoni commented
Status: Needs work » Needs review

The failure mentioned in the comment #4 is due to the change "send "$pass\n" " to "send "$argv\n" " in the git wrapper file.So we have corrected it again to $pass and it is working fine now.

And also i have tested with feature with "git disabled" login,but i noticed that git disabled user do not have permissions to create a sand box project and i am seeing the follow error too while going to the profile page "Your Git access has been suspended by a Drupal.org administrator".

Also added the @clean_data tag at the end of the scenario.

Updated to dev branch .
Please check the commit log: 39f852d

Please review it.

eliza411’s picture

eliza411 commented
Assigned: sachin2dhoni » sdboyer
Status: Needs review » Needs work

sdboyer, can you add another user to the jenkins job?
Call it 'git access' The tests are currently using the Git vetted user for this test and I'm reluctant to take the chance that a failed test of the git access agreement will taint additional tests.

eliza411’s picture

eliza411 commented
Component: Feature/Scenarios » Test data

Setting component to "Test data"

sachin2dhoni’s picture

sachin2dhoni commented

@sdboyer, 'git access' user is not yet created, Please update once done.

eliza411’s picture

eliza411 commented
Assigned: sdboyer » sachin2dhoni
Status: Needs work » Fixed

@sachin2dhoni, the user creation has been added to the jenkins script *has*. Until then, create the user by hand using the 'admin test' account.

The success of the script addition will automatically verified the first time a test calling 'git access' user runs after a clean deployment. If the test fails, this issue can be reopened.

sachin2dhoni’s picture

sachin2dhoni commented
Title: Edit profile tab » Edit profile tab(git_access_check.feature)

Renamed the file from edit_profile.feature to git_access_check.feature and moved to features/git.

Please check the commit log for reference.
http://drupalcode.org/project/doobie.git/commit/45fbca8

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kssundar’s picture

kssundar commented
Version: » 7.x-1.x-dev
Component: Test data » Feature/Scenarios
Assigned: sachin2dhoni » kssundar
Status: Closed (fixed) » Patch (to be ported)
Issue tags: +sprint 17

Need 7.x update

kssundar’s picture

kssundar commented
Status: Patch (to be ported) » Needs review

Ported to 7.x - http://drupalcode.org/project/doobie.git/commit/568fdc5

eliza411’s picture

eliza411 commented
Assigned: kssundar » eliza411
Status: Needs review » Needs work

Assigning so I'll remember to review the first scenario. The final step "Then I initialize the repository" seems like a user action and not an expected outcome (Then I should be able to initialize ... )

kssundar’s picture

kssundar commented
Status: Needs work » Needs review
Issue tags: +sprint 19

Updated accordingly - http://drupalcode.org/project/doobie.git/commit/b551019

eliza411’s picture

eliza411 commented
Status: Needs review » Reviewed & tested by the community

Works for me. Thank you! This is as ready as it can be until the D7 Drupal.org is ready for feedback.

eliza411’s picture

eliza411 commented
Status: Reviewed & tested by the community » Closed (fixed)
eliza411’s picture

eliza411 commented