Mythemes adds a block with a list of all themes and allow users to choose between them to enable and set a default theme. to switch themes on the fly.
The module provides a settings page that allows users to exclude one or more themes from the list, and display or hide messages when a theme has been enabled or set default.The user can also decide if the selected theme must set to default o not.

Links

Version

  • Drupal 7
CommentFileSizeAuthor
mythemes.zip3.5 KBabderrahman83

Comments

abderrahman83’s picture

Issue summary: View changes

Specify the drupal version.

patrickd’s picture

welcome,

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Your existing branch 7.x-1.x-dev does not match the release pattern, also I don't recommend creating any tags before you are able to create releases.

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.
Report: http://ventral.org/pareview/httpgitdrupalorgsandboxabderrahman831706834git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

patrickd’s picture

Assigned: abderrahman83 » Unassigned

also, note that only the current reviewer should assign application issues to hisself

ColonelForbinX’s picture

Consider namespacing your database variables so they are obviously from your module. Pre-pending your module name and an underscore should do the trick.

<?php

function mythemes_uninstall(){
  $variables = array(
    'mythemes_current_theme',
    'mythemes_set_default_theme',
    'mythemes_theme_exclude',
    'mythemes_message_enabled',
    'mythemes_message_default',
    'mythemes_button_text',
  );

  foreach ($variables as $var) {
    variable_del($var);
  }
}

?>
dwieeb’s picture

Can you please list the differences between your module and Switchtheme?

joelrosen’s picture

Status: Needs review » Needs work

I think this should have been set to "needs work" months ago.

webdorado’s picture

We have tested this module for the standard themes of drupal. The module switches some of the standard themes properly, but for the other themes drupal displayed only the text without theme, the theme disappears.

klausi’s picture

@webdorado: please review applications in the "needs review" state. This one is "needs work" and is pending a response from the applicant anyway.

klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

klausi’s picture

Issue summary: View changes

Add a description more detailed.