Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Jul 2012 at 19:18 UTC
Updated:
11 Jan 2013 at 16:25 UTC
Mythemes adds a block with a list of all themes and allow users to choose between them to enable and set a default theme. to switch themes on the fly.
The module provides a settings page that allows users to exclude one or more themes from the list, and display or hide messages when a theme has been enabled or set default.The user can also decide if the selected theme must set to default o not.
| Comment | File | Size | Author |
|---|---|---|---|
| mythemes.zip | 3.5 KB | abderrahman83 |
Comments
Comment #0.0
abderrahman83 commentedSpecify the drupal version.
Comment #1
patrickd commentedwelcome,
You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Your existing branch 7.x-1.x-dev does not match the release pattern, also I don't recommend creating any tags before you are able to create releases.
An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.
Report: http://ventral.org/pareview/httpgitdrupalorgsandboxabderrahman831706834git
We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.
regards
Comment #2
patrickd commentedalso, note that only the current reviewer should assign application issues to hisself
Comment #3
ColonelForbinX commentedConsider namespacing your database variables so they are obviously from your module. Pre-pending your module name and an underscore should do the trick.
Comment #4
dwieeb commentedCan you please list the differences between your module and Switchtheme?
Comment #5
joelrosen commentedI think this should have been set to "needs work" months ago.
Comment #6
webdorado commentedWe have tested this module for the standard themes of drupal. The module switches some of the standard themes properly, but for the other themes drupal displayed only the text without theme, the theme disappears.
Comment #7
klausi@webdorado: please review applications in the "needs review" state. This one is "needs work" and is pending a response from the applicant anyway.
Comment #8
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
Comment #8.0
klausiAdd a description more detailed.