Download & Extend
Chaos tool suite (ctools) » Issues

Allow mockup field settings in ctools_field_invoke_field()

Posted by Amitaibu on August 1, 2012 at 7:57am
Project:Chaos tool suite (ctools)
Version:7.x-1.x-dev
Component:Code
Category:feature request
Priority:major
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Patch allows adding a dummy field settings.

AttachmentSizeStatusTest resultOperations
ctools-fields-mock-field.patch1.27 KBIdlePASSED: [[SimpleTest]]: [MySQL] 58 pass(es).View details
Login or register to post comments

Comments

#1

Posted by Amitaibu on August 16, 2012 at 6:33pm

OG is also going to use it, see screenshot of sub-widgets in #1730678: Provide a "complex" widget instead of "Primary" and "Secondary" fields.

#2

Posted by merlinofchaos on August 18, 2012 at 7:35pm
Status:needs review» needs work

This patch only populates $field if $field_name is an array. That seems like it could lead to errors in other use cases.

#3

Posted by Amitaibu on August 18, 2012 at 8:55pm

This patch only populates $field if $field_name is an array.

The reasons are:

  1. I didn't want to change the function signature
  2. Assuming you need a mocked field, then anyway you'll need to load it and add your own settings

What other solution do you prefer?

That seems like it could lead to errors in other use cases.

All i know is that atleast my current use case(s) for OG and OG-vocab, which creates "sub-widgets" is actually working really nicely thanks to how cool CTools and Field API are :)

#4

Posted by Amitaibu on August 19, 2012 at 11:29am

This patch only populates $field if $field_name is an array.

Re-read, and you are of course correct, ignore #3, patch coming soon :)

#5

Posted by Amitaibu on August 19, 2012 at 11:42am
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
1707810-ctools-fields-mock-field-5.patch1.4 KBIdlePASSED: [[SimpleTest]]: [MySQL] 67 pass(es).View details

#6

Posted by Amitaibu on August 30, 2012 at 8:57pm

Hi guys, OG vocab 7.x-1.x is now using it as-well. Any chance getting this in soon, so testbot won't fail all my tests?

#7

Posted by Amitaibu on September 4, 2012 at 6:11pm

How many mistakes can I make in 3 line patch :/

AttachmentSizeStatusTest resultOperations
1707810-ctools-fields-mock-field-7.patch1.28 KBIdlePASSED: [[SimpleTest]]: [MySQL] 67 pass(es).View details

#8

Posted by Amitaibu on October 21, 2012 at 9:22am

Gentle bump :)

#9

Posted by skyredwang on December 28, 2012 at 3:59am

tested #7 patch. didn't see anything wrong.

#10

Posted by axel.rutz on December 29, 2012 at 7:38pm
Status:needs review» reviewed & tested by the community

reviewed code and can confirm it should do what it says and not harm previous code flow.

so ready to fly.

#11

Posted by axel.rutz on January 16, 2013 at 8:59pm
Priority:normal» major

rising prio as this blocks a stable release of og_vocab as of #6.

#12

Posted by merlinofchaos on February 1, 2013 at 8:44pm
Status:reviewed & tested by the community» fixed

Committed and pushed!

#13

Posted by System Message on February 15, 2013 at 8:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here