Write feature Files for Default Node view: project_release_download_table (Project release).

Comments

kssundar’s picture

Assigned: Unassigned » kssundar
Status: Active » Needs work
kssundar’s picture

Title: Write feature Files for Node view: project_release_download_table » Write feature Files for Node view: project_release_download_table (project_release_download_table.feature)
Status: Needs work » Needs review
StatusFileSize
new7.7 KB

Attached is the patch for this feature. Request to review and share your thoughts.

pradeeprkara’s picture

Title: Write feature Files for Node view: project_release_download_table (project_release_download_table.feature) » Write feature Files for Node view: project_release_download_table
Status: Needs review » Postponed

Possibly delayed until Sprint 3 because Drumm is still coding project_release stuff

kssundar’s picture

It seems my patch submission is missing along with the comment!

Resubmitting the patch.

senpai’s picture

@ksbalajisundar Comment #2 which contained your original patch was 'unpublished', so I re-published it and it shows up now.

eliza411’s picture

Status: Postponed » Active

I believe that this can be worked on now. It needs review for tabbed out table endings and other convensions we've agreed on since you took this on originally.

kssundar’s picture

Status: Active » Needs work
Issue tags: +sprint 7

tagging

kssundar’s picture

Assigned: kssundar » eliza411
Status: Needs work » Needs review

Committed the feature to repo and can be seen here - http://drupalcode.org/project/doobie.git/commit/1d71eba

eliza411’s picture

Assigned: eliza411 » sdboyer

New releases come out fairly frequently so I'm concerned about looking at the specific version numbers

I'm also wondering if we're testing the right thing here, but since I'm not sure how it would go astray (files missing, files not matching their label, wrong contents, etc.) I'm not quite sure how it should be adjusted.

I think I'll leave this one for feedback from sdboyer.

sdboyer’s picture

Status: Needs review » Needs work

sorry for the delay.

testing for dev version strings is a little hinky, but ok. testing for point release strings is definitely not cool.

my ideal approach to this would be that we test the presence of specific versions that we create, but there's a LOT that goes into that. so we can punt on that, probably for quite a while.

a better, but more attainable approach here would be to test that there are releases that conform to the expected patterns, rather than testing for any specific numbers. it may be a little tricky to combine a multiline arg with pattern matching, but i'm sure y'all can figure it out :)

kssundar’s picture

Assigned: sdboyer » kssundar

Lets discuss this on our call today

kssundar’s picture

Status: Needs work » Needs review
Issue tags: +sprint 10

Currently we can write tests as below:

Given I am on "/project/drupal"
When I follow "6.x" "development" version
Then .......
Given I am on "/project/drupal"
When I follow "7.x" "recommended" version
Then .......
Given I am on "/project/drupal"
When I follow "Notes" for "7.x" "development" version
Then .......
Given I am on "/project/drupal"
When I download the "tar" file of "7.x" "recommended" version
Then the downloaded file name should match pattern "drupal-7.x"
eliza411’s picture

Assigned: kssundar » sdboyer

Let's have sdboyer take a look at whether this is what he meant.

eliza411’s picture

Added a wip tag to the first scenario as the contents of the page has changed and the language needs to be updated.

 Scenario: View the list of available releases       # features/project/project_release_download_table.feature:6
    Given that I am on the homepage                   # FeatureContext::thatIAmOnTheHomepage()
    When I follow "Get Started with Drupal"           # FeatureContext::clickLink()
    And I follow "Download Drupal 7."                 # FeatureContext::clickLink()
      Link with id|title|alt|text "Download Drupal 7." not found.
    Then I should see the heading "Download & Extend" # FeatureContext::iShouldSeeTheHeading()
    And I should see the following <texts>            # FeatureContext::iShouldSeeTheFollowingTexts()
      | texts                |
      | Downloads            |
      | Recommended releases |
kssundar’s picture

Assigned: sdboyer » kssundar
Status: Needs review » Needs work

needs work here

kssundar’s picture

Assigned: kssundar » sdboyer
Status: Needs work » Needs review

Sorry, this should have been tagged as @known_git6failure.

This works fine on d.o. The tag is made and committed - http://drupalcode.org/project/doobie.git/commit/760c650

But, still needs review by sdboyer related to #12

kssundar’s picture

Version: » 6.x-1.x-dev
Category: feature » task
Priority: Normal » Major

Setting version and still needs sdboyer's input here.

kssundar’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Assigned: sdboyer » kssundar
Priority: Major » Normal
Status: Needs review » Patch (to be ported)
Issue tags: +sprint 18

Need 7.x update

kssundar’s picture

Assigned: kssundar » Unassigned
Status: Patch (to be ported) » Needs review
eliza411’s picture

Assigned: Unassigned » tvn

Any idea if they're going to stop calling the files tar.gz as is being done on production now and start calling them gz, as we're seeing on git7?

This test is failing appropriately right now - test will need updating if this change is okay.

dww’s picture

eliza411’s picture

Assigned: tvn » Unassigned
Status: Needs review » Reviewed & tested by the community

Thanks dww. We can mark this test rtbc, then. It's as done as it will get until D7 Drupal.org is ready for feedback.

eliza411’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Updated response headers for D7 and verified.