Closed (fixed)
Project:
Drupal.org BDD
Version:
7.x-1.x-dev
Component:
Feature/Scenarios
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Aug 2012 at 15:20 UTC
Updated:
19 Jul 2013 at 15:47 UTC
Jump to comment: Most recent file
Comments
Comment #1
kssundar commentedComment #2
kssundar commentedAttached is the patch for this feature. Request to review and share your thoughts.
Comment #3
pradeeprkara commentedPossibly delayed until Sprint 3 because Drumm is still coding project_release stuff
Comment #4
kssundar commentedIt seems my patch submission is missing along with the comment!
Resubmitting the patch.
Comment #5
senpai commented@ksbalajisundar Comment #2 which contained your original patch was 'unpublished', so I re-published it and it shows up now.
Comment #6
eliza411 commentedI believe that this can be worked on now. It needs review for tabbed out table endings and other convensions we've agreed on since you took this on originally.
Comment #7
kssundar commentedtagging
Comment #8
kssundar commentedCommitted the feature to repo and can be seen here - http://drupalcode.org/project/doobie.git/commit/1d71eba
Comment #9
eliza411 commentedNew releases come out fairly frequently so I'm concerned about looking at the specific version numbers
I'm also wondering if we're testing the right thing here, but since I'm not sure how it would go astray (files missing, files not matching their label, wrong contents, etc.) I'm not quite sure how it should be adjusted.
I think I'll leave this one for feedback from sdboyer.
Comment #10
sdboyer commentedsorry for the delay.
testing for dev version strings is a little hinky, but ok. testing for point release strings is definitely not cool.
my ideal approach to this would be that we test the presence of specific versions that we create, but there's a LOT that goes into that. so we can punt on that, probably for quite a while.
a better, but more attainable approach here would be to test that there are releases that conform to the expected patterns, rather than testing for any specific numbers. it may be a little tricky to combine a multiline arg with pattern matching, but i'm sure y'all can figure it out :)
Comment #11
kssundar commentedLets discuss this on our call today
Comment #12
kssundar commentedCurrently we can write tests as below:
Comment #13
eliza411 commentedLet's have sdboyer take a look at whether this is what he meant.
Comment #14
eliza411 commentedAdded a wip tag to the first scenario as the contents of the page has changed and the language needs to be updated.
Comment #15
kssundar commentedneeds work here
Comment #16
kssundar commentedSorry, this should have been tagged as @known_git6failure.
This works fine on d.o. The tag is made and committed - http://drupalcode.org/project/doobie.git/commit/760c650
But, still needs review by sdboyer related to #12
Comment #17
kssundar commentedSetting version and still needs sdboyer's input here.
Comment #18
kssundar commentedNeed 7.x update
Comment #19
kssundar commentedFeature updated in 7.x branch - http://drupalcode.org/project/doobie.git/commit/2d40f9f
Comment #20
eliza411 commentedAny idea if they're going to stop calling the files tar.gz as is being done on production now and start calling them gz, as we're seeing on git7?
This test is failing appropriately right now - test will need updating if this change is okay.
Comment #21
dwwFixing the filename output is currently blocked on #1791970: Optionally detect tar.* as extension instead of * on views file extension field handler
Comment #22
eliza411 commentedThanks dww. We can mark this test rtbc, then. It's as done as it will get until D7 Drupal.org is ready for feedback.
Comment #23
eliza411 commentedUpdated response headers for D7 and verified.