With OAuth turned *off*, we let people add Twitter accounts to follow without authenticating as that account. But not if OAuth is configured.

By adding an "authenticated" property to TwitterUser we can pick up which mode the account is operating.

CommentFileSizeAuthor
#2 twitter-1710088-auth_no_auth.png45.32 KBxurizaemon
#2 twitter-1710088-auth_no_auth.patch8.2 KBxurizaemon
#1 twitter-1710088-show_authenticated_status.patch3.15 KBxurizaemon

Comments

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
StatusFileSize
new twitter-1710088-show_authenticated_status.patch3.15 KB

Show whether the account is authenticated or not. Just checks if oauth secret is populated or not and sets authenticated propert in TwitterUser. Displays on twitter_account_list_form.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
StatusFileSize
new twitter-1710088-auth_no_auth.patch8.2 KB
new twitter-1710088-auth_no_auth.png45.32 KB

Not sure about how to present two "add account" buttons in close proximity. This looks kinda bung, but it works. The validate functions are a bit lopsided.

juampynr’s picture

juampynr commented

Maybe we could use fieldsets? If not, how about using a checkbox that says 'Do not authenticate'?

dddave’s picture

dddave commented
Version: 7.x-3.x-dev » 7.x-6.x-dev

still relevant?

juampynr’s picture

juampynr commented
Status: Needs work » Closed (won't fix)

Not anymore. Now you can add non-authenticated accounts just when you have authenticated one account with OAuth.

Thanks.