Commerce Checkout Pane Payment

welcome!

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 7 in http://drupal.org/node/1127732

readme.txt must be renamed to README.txt see the guidelines for in-project documentation.
Also have a look at the tips for a great project page.

Unfortunately this project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed (regarding your skills in security and correct api usage). However, we can promote this single project manually to a full project.

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

I tested this using Kickstart and Kickstart 2 and it appears to work in both cases. I've tried it with both the default test payment as well as Authorize.net. Nothing jumps out at me in the code as incorrect.

One suggestion I might make though. If possible it would be nice if on the payment review screen it could show something like "Card ending in 1234" instead of just the payment type I selected.

You've written the module's description that the module is created because of an issue in the module's queue. Can you give a brief explanation why the module you've created should be a seperate module and not a patch for the Drupal Commerce module?

.info file:
The package name should be "Commerce (contrib)" instead of "Commerce (Contrib)".
You don't need to enclose the description with quotes, and better if you end it with a dot.

README.txt:
"This modules allows" should be "This module allows".
Maybe the acknowledgements and the reference to the drupal.org issue would be better at the end of the file, and not merged with the instructions.

All other files look good to me.

Marking it RTBC.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

nielsdefeyter,

Can you confirm that "commerce_checkout_pane_payment" is what you'd like to use as the project shortname (i.e. machine name) on Drupal.org?

Also, could you address the question asked in #5? I wouldn't mind hunting down a Drupal commerce expert to comment on whether this functionality is likely to make it into the Drupal Commerce roadmap before promoting the module; but would like to have your thoughts/opinion on that available before striking up that conversation.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1965468

Project 2: http://drupal.org/node/1710222

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

To any reviewers, ignore #16 ... Based on comments #1 and #2, this is proceeding as a 'module only' approval, and duplicate application is appropriate in this case.

Thanks for your contribution, Niels!

As this is a "module only" approval I've promoted this module to a full project so you can manage its releases and handle it as any other project: http://drupal.org/project/commerce_checkout_pane_payment.

Note:
Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.
git remote set-url origin nielsdefeyter@git.drupal.org:project/commerce_checkout_pane_payment.git

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.