As title says, burdening bootstrap with the check seems unnecessary -- why does it need to be stored in a session and checked every page load? Wrapping it in a function allows it never be checked for certian checks/drush/etc.

Attaching patch, but for d6 version, so not putting it as needs review/work (assuming masquerade is get into 7 first than backport)

CommentFileSizeAuthor
masquerade_hook_init.patch4.39 KBhefox

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

Idea is good but D7 has lazy-session creation so if nothing is stored in session no session would be stored/started. This needs manual review and testing

ressa’s picture

ressa
he/him
commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

Thanks for working on this. In an attempt to help the maintainers, I am going through some of the Drupal 7 issues, and closing them, since Drupal 7 is EOL.

Maintainers should grant credit for the great work to the relevant users, even if the patch did not get committed: https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett....

Since Drupal 7 is EOL, we can probably close this issue, but feel free to re-open if this is still relevant, and we should consider adding this to the Drupal 11 version?

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.