Convert tests to use ::$modules property instead of parent::setUp($modules) [#1711070]

#1380958: Replace $modules list for WebTestBase::setUp() with ::$modules class properties changed how tests declare which modules they depend on. See the change record.

First, assign the issue to yourself, both on the issue and by editing your name into this issue summary table.

For each test class:

Find the setUp() method.
If it passes parent::setUp() an array of modules, add the following at the top of the class, above any other methods or properties:
```
class FooBase extends WebTestBase {

  /**
   * Modules to enable.
   *
   * @var array
   */
  public static $modules = array();
```
Make sure there is a blank line between the class declaration and the docblock.
Note which modules are passed to parent::setUp(), and move them to the $modules array above. Do not remove parent::setUp(); just remove its parameters.
Move any documentation about the enabled modules (in either an inline comment or a docblock) to the docblock for $modules instead.
If the setUp() method is empty except for this line, remove it completely.

You can use this bash command to find relevant setUp() methods: grep -nr "parent::setUp([^)]" *

Module/Directory	Assigned	Issue link
profiles directory	tim.plunkett	#1711436: Convert testing profile tests to use ::$modules property instead of parent::setUp($modules)
aggregator module	kid_icarus	#1711274: Convert aggregator tests to use ::$modules property instead of parent::setUp($modules)
block module	kid_icarus	#1711286: Convert block tests to use ::$modules property instead of parent::setUp($modules)
book module	kid_icarus	#1711290: Convert book tests to use ::$modules property instead of parent::setUp($modules)
color module	kid_icarus	#1711296: Convert color tests to use ::$modules property instead of parent::setUp($modules)
comment module	kid_icarus	#1711298: Convert comment tests to use ::$modules property instead of parent::setUp($modules)
config module	kid_icarus	#1711304: Convert config tests to use ::$modules property instead of parent::setUp($modules)
contact module	kid_icarus	#1711306: Convert contact tests to use ::$modules property instead of parent::setUp($modules)
contextual module	kid_icarus	#1711308: Convert contextual tests to use ::$modules property instead of parent::setUp($modules)
dblog module	kid_icarus	#1711310: Convert dblog tests to use ::$modules property instead of parent::setUp($modules)
entity module	kid_icarus	#1711312: Convert entity tests to use ::$modules property instead of parent::setUp($modules)
field module	kid_icarus	#1711316: Convert field tests to use ::$modules property instead of parent::setUp($modules)
field_ui module	kid_icarus	#1711314: Convert field_ui tests to use ::$modules property instead of parent::setUp($modules)
file module	zendoodles	#1711344: Convert file tests to use ::$modules property instead of parent::setUp($modules)
filter module	kid_icarus	#1711346: Convert filter tests to use ::$modules property instead of parent::setUp($modules)
forum module	kid_icarus	#1711348: Convert forum tests to use ::$modules property instead of parent::setUp($modules)
help module	kid_icarus	#1711350: Convert help tests to use ::$modules property instead of parent::setUp($modules)
image module	zendoodles	#1711352: Convert image tests to use ::$modules property instead of parent::setUp($modules)
language module	tim.plunkett	#1711356: Convert language tests to use ::$modules property instead of parent::setUp($modules)
locale module	cam8001	#1711394: Convert locale tests to use ::$modules property instead of parent::setUp($modules)
menu module	zendoodles	#1711396: Convert menu tests to use ::$modules property instead of parent::setUp($modules)
node module	tim.plunkett	#1710300: Convert node tests to use ::$modules property instead of parent::setUp($modules)
openid module	tim.plunkett	#1711398: Convert openid tests to use ::$modules property instead of parent::setUp($modules)
overlay module	N/A	N/A
path module	kid_icarus	#1711400: Convert path tests to use ::$modules property instead of parent::setUp($modules)
php module	kid_icarus	#1711402: Convert php tests to use ::$modules property instead of parent::setUp($modules)
poll module	kid_icarus	#1711404: Convert poll tests to use ::$modules property instead of parent::setUp($modules)
rdf module	kid_icarus	#1711408: Convert rdf tests to use ::$modules property instead of parent::setUp($modules)
search module	xjm	#1711418: Convert search tests to use ::$modules property instead of parent::setUp($modules)
shortcut module	droplet	#1711410: Convert shortcut tests to use ::$modules property instead of parent::setUp($modules)
simpletest module	tim.plunkett	#1711412: Convert simpletest tests to use ::$modules property instead of parent::setUp($modules)
statistics module	droplet	#1711414: Convert statistics tests to use ::$modules property instead of parent::setUp($modules)
syslog module	kid_icarus	#1711416: Convert syslog tests to use ::$modules property instead of parent::setUp($modules)
system module	cam8001	#1711424: Convert system tests to use ::$modules property instead of parent::setUp($modules)
taxonomy module	xjm	#1711426: Convert taxonomy tests to use ::$modules property instead of parent::setUp($modules)
toolbar module	N/A	N/A
tracker module	tim.plunkett	#1711428: Convert tracker tests to use ::$modules property instead of parent::setUp($modules)
translation module	droplet	#1711430: Convert translation tests to use ::$modules property instead of parent::setUp($modules)
update module	droplet	#1711432: Convert update tests to use ::$modules property instead of parent::setUp($modules)
user module	tim.plunkett	#1711434: Convert user tests to use ::$modules property instead of parent::setUp($modules)
xmlrpc module	droplet	#1711440: Convert xmlrpc tests to use ::$modules property instead of parent::setUp($modules)

Once all those are done, commit #1711076: Remove setUp as a means of enabling modules

Comment	File	Size	Author
#14	drupal-1711070-14.patch	261.62 KB	tim.plunkett
#14	interdiff.txt	1.37 KB	tim.plunkett
#12	drupal-1711070-12.patch	260.25 KB	tim.plunkett
#10	drupal-1711070-10.patch	260.12 KB	tim.plunkett
#8	drupal-1711070-8.patch	259.19 KB	tim.plunkett
#5	drupal-1711070-5.patch	259.08 KB	tim.plunkett

Comments

Comment #0.0

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 22:41

Issue summary:

View changes

put ol around steps

Comment #1

sun

German

Karlsruhe

commented 2 August 2012 at 23:03

Title:	[meta] Convert tests to use ::$modules instead of ::setUp($modules)	» [meta] Convert tests to use ::$modules property instead of parent::setUp($modules)
Issue tags:		+Novice, +Testing system

Thanks! Slightly adjusting title and tagging.

Comment #1.0

sun

German

Karlsruhe

commented 2 August 2012 at 23:03

Issue summary:

View changes

added #1711076

Comment #1.1

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:13

Issue summary:

View changes

Updated issue summary.

Comment #1.2

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:16

Issue summary:

View changes

Updated issue summary.

Comment #1.3

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:16

Issue summary:

View changes

Updated issue summary.

Comment #1.4

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:20

Issue summary:

View changes

Updated issue summary.

Comment #1.5

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:22

Issue summary:

View changes

Updated issue summary.

Comment #1.6

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:37

Issue summary:

View changes

Updated issue summary.

Comment #1.7

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:46

Issue summary:

View changes

Updated issue summary.

Comment #1.8

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:51

Issue summary:

View changes

Updated issue summary.

Comment #1.9

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:56

Issue summary:

View changes

Updated issue summary.

Comment #1.10

tim.plunkett

he/him

English

Philadelphia

commented 2 August 2012 at 23:59

Issue summary:

View changes

Updated issue summary.

Comment #1.11

xjm

she/her

English

commented 3 August 2012 at 00:05

Issue summary:

View changes

Comment #1.12

xjm

she/her

English

commented 3 August 2012 at 00:06

Issue summary:

View changes

Updated issue summary.

Comment #1.13

tim.plunkett

he/him

English

Philadelphia

commented 3 August 2012 at 00:07

Issue summary:

View changes

Updated issue summary.

Comment #1.14

tim.plunkett

he/him

English

Philadelphia

commented 3 August 2012 at 02:04

Issue summary:

View changes

added kid_icarus

Comment #1.15

tim.plunkett

he/him

English

Philadelphia

commented 3 August 2012 at 02:10

Issue summary:

View changes

added instruction about assigning

Comment #1.16

tim.plunkett

he/him

English

Philadelphia

commented 3 August 2012 at 02:26

Issue summary:

View changes

Updated issue summary.

Comment #1.17

tim.plunkett

he/him

English

Philadelphia

commented 3 August 2012 at 02:34

Issue summary:

View changes

Updated issue summary.

Comment #1.18

kid_icarus commented 3 August 2012 at 02:46

Issue summary:

View changes

Added kid_icarus to comment module

Comment #1.19

kid_icarus commented 3 August 2012 at 02:52

Issue summary:

View changes

Added kid_icarus to config module

Comment #1.20

kid_icarus commented 3 August 2012 at 03:01

Issue summary:

View changes

Added kid_icarus to contact module

Comment #1.21

kid_icarus commented 3 August 2012 at 03:08

Issue summary:

View changes

Added kid_icarus to contextual module

Comment #1.22

kid_icarus commented 3 August 2012 at 03:14

Issue summary:

View changes

Added kid_icarus to entity module

Comment #1.23

kid_icarus commented 3 August 2012 at 03:30

Issue summary:

View changes

Added kid_icarus to field module

Comment #1.24

kid_icarus commented 3 August 2012 at 03:34

Issue summary:

View changes

Added kid_icarus to field_ui module

Comment #1.25

tim.plunkett

he/him

English

Philadelphia

commented 3 August 2012 at 03:37

Issue summary:

View changes

Updated issue summary.

Comment #1.26

kid_icarus commented 3 August 2012 at 03:42

Issue summary:

View changes

Added kid_icarus to filter module

Comment #1.27

kid_icarus commented 3 August 2012 at 03:48

Issue summary:

View changes

Added kid_icarus to forum module

Comment #1.28

kid_icarus commented 3 August 2012 at 03:52

Issue summary:

View changes

Added kid_icarus to help module

Comment #1.29

kid_icarus commented 3 August 2012 at 04:38

Issue summary:

View changes

Added kid_icarus to php module

Comment #1.30

xjm

she/her

English

commented 3 August 2012 at 15:47

Issue summary:

View changes

Updated issue summary.

Comment #1.31

xjm

she/her

English

commented 3 August 2012 at 16:53

Issue summary:

View changes

Updated issue summary.

Comment #2

xjm

she/her

English

commented 3 August 2012 at 16:55

Updated the summary with instructions that conform to our coding standards from http://drupal.org/node/1354#classes.

Comment #2.0

xjm

she/her

English

commented 3 August 2012 at 16:55

Issue summary:

View changes

Updated issue summary.

Comment #2.1

ZenDoodles commented 3 August 2012 at 18:03

Issue summary:

View changes

Updated issue summary.

Comment #2.2

xjm

she/her

English

commented 3 August 2012 at 19:45

Issue summary:

View changes

Comment #2.3

cameron tod commented 3 August 2012 at 19:59

Issue summary:

View changes

Assigned myself to the locale module.

Comment #2.4

xjm

she/her

English

commented 4 August 2012 at 01:14

Issue summary:

View changes

Updated issue summary.

Comment #2.5

xjm

she/her

English

commented 4 August 2012 at 11:12

Issue summary:

View changes

Updated issue summary.

Comment #2.6

tim.plunkett

he/him

English

Philadelphia

commented 4 August 2012 at 18:09

Issue summary:

View changes

Updated issue summary.

Comment #2.7

tim.plunkett

he/him

English

Philadelphia

commented 4 August 2012 at 18:16

Issue summary:

View changes

Updated issue summary.

Comment #2.8

tim.plunkett

he/him

English

Philadelphia

commented 4 August 2012 at 18:32

Issue summary:

View changes

Updated issue summary.

Comment #2.9

tim.plunkett

he/him

English

Philadelphia

commented 4 August 2012 at 18:49

Issue summary:

View changes

Updated issue summary.

Comment #2.10

xjm

she/her

English

commented 4 August 2012 at 21:50

Issue summary:

View changes

Updated issue summary.

Comment #2.11

cameron tod commented 5 August 2012 at 00:33

Issue summary:

View changes

Assigned myself to system.module.

Comment #3

webchick

she/they

English

Vancouver 🇨🇦

commented 7 August 2012 at 19:24

Is there any way we could get just one mega-patch with all of these? This is currently clobbering the RTBC queue with 500 issues that are each going to take 1-2 minutes to process.

Comment #4

cameron tod commented 8 August 2012 at 09:03

Should we wait till they are all RTBC individually, then roll the patches up together?

Comment #4.0

kid_icarus commented 8 August 2012 at 16:53

Issue summary:

View changes

Assigned kid_icarus to path module

Comment #5

tim.plunkett

he/him

English

Philadelphia

commented 9 August 2012 at 20:36

Status	File	Size
new	drupal-1711070-5.patch	259.08 KB

All but three of the issues were RTBC, and I personally reviewed and finished those.

Here's the whole thing.

Comment #6

tim.plunkett

he/him

English

Philadelphia

commented 9 August 2012 at 20:36

Title:	[meta] Convert tests to use ::$modules property instead of parent::setUp($modules)	» Convert tests to use ::$modules property instead of parent::setUp($modules)
Assigned:	Unassigned	» tim.plunkett
Status:	Active	» Needs review