I just downloaded Drupal 4.5.2 and in the database.mysql file, there was an error in one of the SQL statements.

In the CREATE TABLE filter_formats statement (lines 243-249), the error is on line 248.

That line reads, PRIMARY KEY format (format)

If should read, PRIMARY KEY (format)

CommentFileSizeAuthor
#4 dbtweak.patch8.42 KBdrumm
#3 01_dbtweak.patch14.83 KBmorbus iff
#1 database.mysql19.66 KBJiminator

Comments

Jiminator’s picture

Jiminator commented
StatusFileSize
new database.mysql19.66 KB

I posted this, but didn't have a log in at the time. I'm attaching the corrected file.

Jiminator.

jeremy’s picture

jeremy commented
Project: Database Administration » Drupal core
Component: Code » database system

This bug was mis-advertantly assigned to the dba module. It's regarding the core mysql database file. Reassigning.

morbus iff’s picture

morbus iff
they/them
commented
Title: SQL error in database.mysql » Whitespace/PRIMARY KEY standardizations for the SQL files.
Assigned: Unassigned » morbus iff
StatusFileSize
new 01_dbtweak.patch14.83 KB

I could not replicate the error in HEAD with MySQL 4.0.15: the database.mysql imported just fine, and the primary key was set properly for the format column. With that said, this particular line does not follow the format of any of the other PRIMARY KEYs in the MySQL file, and thus, attached is a patch to standardize the format PRIMARY KEYs are defined, as well as whitespacing. Same goes for the pgsql file.

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: morbus iff » drumm
StatusFileSize
new dbtweak.patch8.42 KB

The whitespacing in the mysql file is fixed in HEAD. Attached is a patch to remove a couple random double spaces and remove the double spacing in the pgsql file.

drumm’s picture

drumm
he/him
Location NY, US
commented
Steven’s picture

Steven commented

Commited to HEAD.

Steven’s picture

Steven commented
Status: Needs review » Fixed
Anonymous’s picture

(not verified) commented
drumm’s picture

drumm
he/him
Location NY, US
commented
Version: » 4.6.0
Status: Fixed » Closed (fixed)